From: Amos Kong <akong@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, arei.gonglei@huawei.com,
qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest
Date: Thu, 19 Jun 2014 11:57:45 +0800 [thread overview]
Message-ID: <20140619035744.GD32534@z.redhat.com> (raw)
In-Reply-To: <20140619034908.GC21236@stefanha-thinkpad.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On Thu, Jun 19, 2014 at 11:49:08AM +0800, Stefan Hajnoczi wrote:
> On Thu, Jun 19, 2014 at 12:24:13AM +0800, Amos Kong wrote:
> > + for (i = MIN_PCI_SLOT; i <= MAX_PCI_SLOT; i++) {
> > + for (j = MAX_PCI_FUNC; j >= 0; j--) {
> > + if (j == MAX_PCI_FUNC) {
> > + qmp_exec_hmp_cmd("", "drive_del drv-%x.%x", i, 0);
> > + }
>
> Why is only drv-%x.0 deleted? Previous revisions of this patch series
> deleted all drives.
Hot-unplug any single function, all functions in the slot will be
removed. So once is enough.
> Stefan
--
Amos.
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-19 3:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 16:24 [Qemu-devel] [PATCH v5 0/4] test virtio-blk hotplug Amos Kong
2014-06-18 16:24 ` [Qemu-devel] [PATCH v5 1/4] qtest: introduce qmp_exec_hmp_cmd() Amos Kong
2014-06-18 16:24 ` [Qemu-devel] [PATCH v5 2/4] qtest: use qmp_exec_hmp_cmd() in blockdev-test Amos Kong
2014-06-18 16:24 ` [Qemu-devel] [PATCH v5 3/4] virtio-blk-test.c: change pci_nop() to virtblk_init() Amos Kong
2014-06-18 16:43 ` Andreas Färber
2014-06-19 4:41 ` Amos Kong
2014-06-18 16:24 ` [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest Amos Kong
2014-06-19 3:49 ` Stefan Hajnoczi
2014-06-19 3:57 ` Amos Kong [this message]
2014-06-19 4:03 ` Gonglei (Arei)
2014-06-19 4:38 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619035744.GD32534@z.redhat.com \
--to=akong@redhat.com \
--cc=afaerber@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.