From: Tony Lindgren <tony@atomide.com>
To: Daniel Mack <daniel@zonque.org>
Cc: linux-usb@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
linux-omap@vger.kernel.org, george.cherian@ti.com
Subject: Re: Gadget regression with enabling of MUSB babble interrupt handling
Date: Thu, 19 Jun 2014 03:31:01 -0700 [thread overview]
Message-ID: <20140619103100.GB29055@atomide.com> (raw)
In-Reply-To: <53A2B6B0.2040804@zonque.org>
* Daniel Mack <daniel@zonque.org> [140619 03:10]:
> (+ George)
>
> On 06/19/2014 11:56 AM, Tony Lindgren wrote:
> > Looks like commit ca88fc2ef0d7 (usb: musb: add a work_struct
> > to recover from babble errors) causes MUSB gadgets to stop
> > enumerating at least on omap3. Reverting the the commit fixes
> > the issue.
>
> Hmm, so do you see babble errors occuring?
Not that I noticed of.
> Also, there are some more patches for musb and babble error recovery on
> the usb list, namely the ones starting here in v6:
>
> http://marc.info/?l=linux-usb&m=140109627505065&w=4
>
> Care to give them a try?
I can confirm that "[PATCH v6 1/5] usb: musb: core: Handle Babble
condition only in HOST mode" fixes the issue for me. Also the
explanation in the patch description explains why it breaks, and
probably for all gadgets too because "BABBLE and RESET share the
same interrupt" so it's RESET in peripheral mode.
But that also raises a question: Were these patches merged for
v3.16 ever even tested in peripheral mode?
Regards,
Tony
next prev parent reply other threads:[~2014-06-19 10:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 9:56 Gadget regression with enabling of MUSB babble interrupt handling Tony Lindgren
[not found] ` <20140619095655.GA29055-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-06-19 10:08 ` Daniel Mack
2014-06-19 10:31 ` Tony Lindgren [this message]
2014-06-19 10:36 ` Daniel Mack
[not found] ` <53A2BD34.1060409-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>
2014-06-19 10:43 ` Tony Lindgren
[not found] ` <20140619104324.GC29055-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-06-19 10:50 ` Daniel Mack
2014-06-19 11:24 ` Tony Lindgren
2014-06-20 3:41 ` George Cherian
2014-06-20 6:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619103100.GB29055@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=daniel@zonque.org \
--cc=george.cherian@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.