From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxdwK-0002Ul-Ki for qemu-devel@nongnu.org; Thu, 19 Jun 2014 11:07:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxdwB-0003rI-26 for qemu-devel@nongnu.org; Thu, 19 Jun 2014 11:07:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxdwA-0003r5-Px for qemu-devel@nongnu.org; Thu, 19 Jun 2014 11:07:38 -0400 Date: Thu, 19 Jun 2014 11:07:34 -0400 From: Luiz Capitulino Message-ID: <20140619110734.3ba1463e@redhat.com> In-Reply-To: References: <1403188615-17456-1-git-send-email-lcapitulino@redhat.com> <1403188615-17456-2-git-send-email-lcapitulino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] fpu: softfloat: drop INLINE macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Thu, 19 Jun 2014 15:59:35 +0100 Peter Maydell wrote: > On 19 June 2014 15:36, Luiz Capitulino wrote: > > This commit expands all uses of the INLINE macro and drop it. > > > > The reason for this is to avoid clashes with external libraries with > > bad name conventions and also because renaming keywords is not a good > > practice. > > > > Signed-off-by: Luiz Capitulino > > --- > > fpu/softfloat-macros.h | 38 +++++++++---------- > > fpu/softfloat.c | 48 ++++++++++++------------ > > include/fpu/softfloat.h | 99 ++++++++++++++++++++++++------------------------- > > 3 files changed, 92 insertions(+), 93 deletions(-) > > I need a statement that you're happy for this change to > be licensed under either the softfloat-2a or softfloat-2b > licenses before we can apply it. (We're still hoping to > make that licensing change...) I'm fine with softfloat-2a.