Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Jun 16, 2014 at 01:29:08PM -0400, Gabriel L. Somlo wrote:
> This series contains a few fixes and improvements in the emulation
> of link auto-negotiation:
> 
>   - use auto-negotiation when the link is bounced externally (e.g. via
>     set_link <foo> down/up on the qemu monitor command line).
> 
>   - allow mii_tool on linux access to all the phy registers and flags
>     it requires in order to report a successfully auto-negotiated link.
> 
>   - inject LSC interrupt upon successful link auto-negotiation (required
>     by stock OS X e1000 driver).
> 
> See additional prose following commit logs in 2/3 (making up excuses
> for checkpatch error) and 3/3 (further thoughts on OS X vs. Linux/Windows
> re. auto-negotiation and LSC injection).
> 
> Thanks much,
>   Gabriel

Looks good to me.
We should be careful to bring link immediately up and not to run the
timer if running in legacy pc compatibility mode:

QEMU 1.3 does not support link auto-negotiation emulation, so if we
migrate during auto negotiation, after migration the link will be
down.


> Gabriel L. Somlo (3):
>   e1000: emulate auto-negotiation during external link status change
>   e1000: improve auto-negotiation reporting via mii-tool
>   e1000: signal guest on successful link auto-negotiation
> 
>  hw/net/e1000.c      | 24 +++++++++++++++++++-----
>  hw/net/e1000_regs.h |  3 +++
>  2 files changed, 22 insertions(+), 5 deletions(-)
> 
> -- 
> 1.9.3