From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] [RFC] drm/i915/dp: add support for load detect Apple DP->VGA dongles
Date: Thu, 19 Jun 2014 22:48:45 +0200 [thread overview]
Message-ID: <20140619204845.GC5821@phenom.ffwll.local> (raw)
In-Reply-To: <87y4xacqcl.fsf@intel.com>
On Fri, Jun 06, 2014 at 12:57:46PM +0300, Jani Nikula wrote:
> On Fri, 06 Jun 2014, Dave Airlie <airlied@gmail.com> wrote:
> > From: Dave Airlie <airlied@redhat.com>
> >
> > The DP1.2 spec has some bits for forced load sensing on VGA dongles,
> > however the apple dongle I have doesn't do DP 1.2 yet, so I dug into
> > its vendor specific area and found a register that seems to correspond
> > to load detected on the outputs.
> >
> > The main reason I need this was at LCA this year the slide capture system
> > failed to provide EDID, but I realised OSX worked. Really need to add support
> > to nouveau, but hey i915 is a start.
> >
> > The dongle also appears to use short IRQs to denote a plug/unplug event,
> > though something seems to be failing in reading back the dpcd values from it.
> > (also this is based on my MST work just because.)
>
> Good timing for making use of the OUI! See
>
> http://mid.gmane.org/1401920981-3137-1-git-send-email-clinton.a.taylor@intel.com
>
> > Signed-off-by: Dave Airlie <airlied@redhat.com>
Just a high-level bikeshed: Now that we have this nice dp helper library
shouldn't we add a dp_detect function there which fills out a bunch of
sink state in the core dp struct and also implements tricks like this?
Maybe as the plain dp version of the relevant dp mst handler?
Definitely not much point in copy&pasting this for radeon, noveau, tegra
and all the others.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-06-19 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 2:56 [PATCH] [RFC] drm/i915/dp: add support for load detect Apple DP->VGA dongles Dave Airlie
2014-06-06 9:57 ` Jani Nikula
2014-06-19 20:48 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619204845.GC5821@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.