All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: jeff.liu@oracle.com
Cc: netdev@vger.kernel.org
Subject: re: net: return actual error on register_queue_kobjects
Date: Fri, 20 Jun 2014 00:28:40 +0300	[thread overview]
Message-ID: <20140619212840.GA15522@mwanda> (raw)

Hello Jie Liu,

The patch d36a4f4b4723: "net: return actual error on
register_queue_kobjects" from Jun 17, 2014, leads to the following
static checker warning:

	net/core/net-sysfs.c:1203 register_queue_kobjects()
	warn: 'net->queues_kset' isn't an ERR_PTR

net/core/net-sysfs.c
  1200  #ifdef CONFIG_SYSFS
  1201          net->queues_kset = kset_create_and_add("queues",
                                   ^^^^^^^^^^^^^^^^^^^
This function returns a NULL on error doesn't it?  In linux-next it
does.  The patch description is not clear.

  1202              NULL, &net->dev.kobj);
  1203          if (IS_ERR(net->queues_kset))
  1204                  return PTR_ERR(net->queues_kset);
  1205          real_rx = net->real_num_rx_queues;
  1206  #endif

regards,
dan carpenter

             reply	other threads:[~2014-06-19 21:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19 21:28 Dan Carpenter [this message]
2014-06-19 21:39 ` net: return actual error on register_queue_kobjects Alexei Starovoitov
2014-06-20  1:12 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140619212840.GA15522@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=jeff.liu@oracle.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.