From: Greg KH <gregkh@linuxfoundation.org>
To: James A Shackleford <shack@linux.com>
Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: vt6655: update out-of-date function declaration
Date: Thu, 19 Jun 2014 16:35:02 -0700 [thread overview]
Message-ID: <20140619233502.GA10708@kroah.com> (raw)
In-Reply-To: <1401675573-27734-1-git-send-email-shack@linux.com>
On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote:
> The function iwctl_siwscan() is defined in iwctl.c as:
> int iwctl_siwscan(struct net_device *dev,
> struct iw_request_info *info,
> struct iw_point *wrq,
> char *extra)
> {
> ...
>
> This patch updates iwctl.h so that the type of the 3rd parameter (*wqr) in the
> function declaration matches the definition.
>
> Signed-off-by: James A Shackleford <shack@linux.com>
> ---
> drivers/staging/vt6655/iwctl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h
> index 871bd7c..4ad5e48 100644
> --- a/drivers/staging/vt6655/iwctl.h
> +++ b/drivers/staging/vt6655/iwctl.h
> @@ -168,7 +168,7 @@ int iwctl_giwscan(struct net_device *dev,
>
> int iwctl_siwscan(struct net_device *dev,
> struct iw_request_info *info,
> - struct iw_param *wrq,
> + struct iw_point *wrq,
> char *extra);
>
Why isn't the compiler catching this issue? Should something include
this .h file?
thanks,
greg k-h
next prev parent reply other threads:[~2014-06-19 23:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 2:19 [PATCH 1/3] staging: vt6655: update out-of-date function declaration James A Shackleford
2014-06-02 2:19 ` [PATCH 2/3] staging: vt6655: update iwctl_private_args extern declaration James A Shackleford
2014-06-02 2:19 ` [PATCH 3/3] staging: vt6655: fix sparse warning for static declarations James A Shackleford
2014-06-19 23:35 ` Greg KH [this message]
2014-06-20 20:31 ` [PATCH 1/3] staging: vt6655: update out-of-date function declaration James A. Shackleford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619233502.GA10708@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shack@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.