From: Greg Kroah-Hartman <greg@kroah.com>
To: pramod.gurav.etc@gmail.com
Cc: linux-kernel@vger.kernel.org, Brian Swetland <swetland@google.com>
Subject: Re: [PATCH v2 2/2] staging: alarm-dev: Support to Compile as Module
Date: Thu, 19 Jun 2014 17:31:55 -0700 [thread overview]
Message-ID: <20140620003155.GA4647@kroah.com> (raw)
In-Reply-To: <1402640383-13324-2-git-send-email-pramod.gurav.etc@gmail.com>
On Fri, Jun 13, 2014 at 11:49:43AM +0530, pramod.gurav.etc@gmail.com wrote:
> From: Pramod Gurav <pramod.gurav.etc@gmail.com>
>
> Currently this alarm-dev can be compiles only as built in
> driver. This adds support to compile it as module as well which is in
> planned activity (See drivers/staging/android/TODO)
>
>
> CC: Greg Kroah-Hartman <greg@kroah.com>
> CC: Brian Swetland <swetland@google.com>
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
> ---
> drivers/staging/android/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index 99e484f..c359317 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -76,7 +76,7 @@ config ANDROID_LOW_MEMORY_KILLER
> Registers processes to be killed when memory is low
>
> config ANDROID_INTF_ALARM_DEV
> - bool "Android alarm driver"
> + tristate "Android alarm driver"
> depends on RTC_CLASS
> default n
> ---help---
With this change you will get a warning about a missing
MODULE_LICENSE(), can you please send a follow-on patch to fix that?
thanks,
greg k-h
prev parent reply other threads:[~2014-06-20 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 6:19 [PATCH v2 1/2] alarmtimer: Export symbols of alarmtimer_get_rtcdev pramod.gurav.etc
2014-06-13 6:19 ` [PATCH v2 2/2] staging: alarm-dev: Support to Compile as Module pramod.gurav.etc
2014-06-20 0:31 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620003155.GA4647@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pramod.gurav.etc@gmail.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.