From: Greg KH <greg@kroah.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Haiyang Zhang <haiyangz@microsoft.com>,
netdev@vger.kernel.org, jasowang@redhat.com,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event
Date: Thu, 19 Jun 2014 22:12:13 -0700 [thread overview]
Message-ID: <20140620051213.GA9960@kroah.com> (raw)
In-Reply-To: <20140620045704.GA4850@aepfle.de>
On Fri, Jun 20, 2014 at 06:57:04AM +0200, Olaf Hering wrote:
> On Thu, Jun 19, Haiyang Zhang wrote:
>
> > The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host
> > sleep or hibernation. We refresh network at this time.
>
> > + char *argv[] = { "/etc/init.d/network", "restart", NULL };
>
> What happens if that file does not exist? Dead network in the guest?
> I tend to think if a VM with PV drivers goes to sleep it has to go
> through the whole suspend/resume cycle, very much like the "LID closed"
> event. So I think this and the other fbdev change that is floating
> around is wrong.
Ah, and what about systems with no /etc/init.d/ at all (like
systemd-based ones)? You can't have a kernel driver ask userspace to
restart all networking connections, that seems really wrong.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: jasowang@redhat.com, netdev@vger.kernel.org,
Haiyang Zhang <haiyangz@microsoft.com>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event
Date: Thu, 19 Jun 2014 22:12:13 -0700 [thread overview]
Message-ID: <20140620051213.GA9960@kroah.com> (raw)
In-Reply-To: <20140620045704.GA4850@aepfle.de>
On Fri, Jun 20, 2014 at 06:57:04AM +0200, Olaf Hering wrote:
> On Thu, Jun 19, Haiyang Zhang wrote:
>
> > The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host
> > sleep or hibernation. We refresh network at this time.
>
> > + char *argv[] = { "/etc/init.d/network", "restart", NULL };
>
> What happens if that file does not exist? Dead network in the guest?
> I tend to think if a VM with PV drivers goes to sleep it has to go
> through the whole suspend/resume cycle, very much like the "LID closed"
> event. So I think this and the other fbdev change that is floating
> around is wrong.
Ah, and what about systems with no /etc/init.d/ at all (like
systemd-based ones)? You can't have a kernel driver ask userspace to
restart all networking connections, that seems really wrong.
greg k-h
next prev parent reply other threads:[~2014-06-20 5:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 1:34 [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event Haiyang Zhang
2014-06-20 1:34 ` Haiyang Zhang
2014-06-20 4:21 ` David Miller
2014-06-20 4:21 ` David Miller
2014-06-20 4:57 ` Olaf Hering
2014-06-20 5:12 ` Greg KH [this message]
2014-06-20 5:12 ` Greg KH
2014-06-20 16:09 ` Haiyang Zhang
2014-06-23 8:02 ` Olaf Hering
2014-06-23 12:47 ` Haiyang Zhang
2014-06-23 12:47 ` Haiyang Zhang
2014-06-23 13:17 ` Olaf Hering
2014-06-23 13:17 ` Olaf Hering
2014-06-23 16:09 ` Haiyang Zhang
2014-06-23 16:09 ` Haiyang Zhang
2014-06-23 16:27 ` Olaf Hering
2014-06-23 18:21 ` Haiyang Zhang
2014-06-23 18:21 ` Haiyang Zhang
2014-06-26 8:45 ` Olaf Hering
2014-06-26 8:45 ` Olaf Hering
2014-06-26 14:55 ` Haiyang Zhang
2014-06-26 14:55 ` Haiyang Zhang
2014-06-23 16:29 ` Greg KH
2014-06-23 18:23 ` Haiyang Zhang
2014-06-23 20:11 ` David Miller
2014-06-23 20:11 ` David Miller
2014-06-23 20:10 ` David Miller
2014-06-23 20:10 ` David Miller
2014-06-23 20:17 ` Haiyang Zhang
2015-10-27 22:36 ` Richard Weinberger
2015-10-27 22:36 ` Richard Weinberger
2015-10-28 17:59 ` Haiyang Zhang
2015-10-28 17:59 ` Haiyang Zhang
2015-10-29 19:09 ` Haiyang Zhang
2015-10-29 19:09 ` Haiyang Zhang
2015-10-30 10:56 ` Vitaly Kuznetsov
2015-10-30 22:03 ` Haiyang Zhang
2015-10-30 22:10 ` Richard Weinberger
2014-06-23 20:06 ` David Miller
2014-06-23 20:06 ` David Miller
2014-06-20 8:41 ` Dan Carpenter
2014-06-20 8:41 ` Dan Carpenter
2014-06-20 15:48 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620051213.GA9960@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.