All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Doug Anderson <dianders@chromium.org>,
	Amit Daniel Kachhap <amit.daniel@samsung.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Riley <davidriley@chromium.org>,
	Jonathan Austin <Jonathan.Austin@arm.com>
Subject: Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay
Date: Fri, 20 Jun 2014 09:15:09 +0100	[thread overview]
Message-ID: <20140620081509.GA25104@arm.com> (raw)
In-Reply-To: <53A31291.9000007@gmail.com>

On Thu, Jun 19, 2014 at 05:40:49PM +0100, Tomasz Figa wrote:
> On 19.06.2014 18:31, Doug Anderson wrote:
> >>> My personal vote would be to submit a patch to change "cycles_t" to
> >>> always be 32-bits.  Given that 32-bits was fine for udelay() for ARM
> >>> that seems sane and simple.  If someone later comes up with a super
> >>> compelling reason why we need 64-bit timers for udelay (really??) then
> >>> they can later add all the complexity needed.
> >>
> >> Yes, this could work. I'm not sure what else cycles_t is used for, though.
> > 
> > True, it is a bit questionable to change this since it's a type that's
> > not obviously just for udelay().  Perhaps a better option would be to
> > make a new typedef for the result of read_current_timer().  ...or just
> > change it to return a u32?
> > 
> 
> Sounds good to me, but let's hear other opinions. I'm adding Will and
> Jonathan as they wrote the ARM delay timer code.

I think cycles_t is only used for small interval calculations at the moment,
but I remember Ted mentioning something about using it (or something
similar) as a source of early entropy, in which case the more bits the
better.

That said, I can't find any code in the tree to that effect.

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay
Date: Fri, 20 Jun 2014 09:15:09 +0100	[thread overview]
Message-ID: <20140620081509.GA25104@arm.com> (raw)
In-Reply-To: <53A31291.9000007@gmail.com>

On Thu, Jun 19, 2014 at 05:40:49PM +0100, Tomasz Figa wrote:
> On 19.06.2014 18:31, Doug Anderson wrote:
> >>> My personal vote would be to submit a patch to change "cycles_t" to
> >>> always be 32-bits.  Given that 32-bits was fine for udelay() for ARM
> >>> that seems sane and simple.  If someone later comes up with a super
> >>> compelling reason why we need 64-bit timers for udelay (really??) then
> >>> they can later add all the complexity needed.
> >>
> >> Yes, this could work. I'm not sure what else cycles_t is used for, though.
> > 
> > True, it is a bit questionable to change this since it's a type that's
> > not obviously just for udelay().  Perhaps a better option would be to
> > make a new typedef for the result of read_current_timer().  ...or just
> > change it to return a u32?
> > 
> 
> Sounds good to me, but let's hear other opinions. I'm adding Will and
> Jonathan as they wrote the ARM delay timer code.

I think cycles_t is only used for small interval calculations at the moment,
but I remember Ted mentioning something about using it (or something
similar) as a source of early entropy, in which case the more bits the
better.

That said, I can't find any code in the tree to that effect.

Will

  reply	other threads:[~2014-06-20  8:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19  8:39 [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay Amit Daniel Kachhap
2014-06-19  8:39 ` Amit Daniel Kachhap
2014-06-19  9:11 ` Daniel Lezcano
2014-06-19  9:11   ` Daniel Lezcano
2014-06-19 10:21   ` amit daniel kachhap
2014-06-19 10:21     ` amit daniel kachhap
2014-06-19 10:29     ` Arnd Bergmann
2014-06-19 10:29       ` Arnd Bergmann
2014-06-19 10:30     ` Daniel Lezcano
2014-06-19 10:30       ` Daniel Lezcano
2014-06-19 11:00       ` amit daniel kachhap
2014-06-19 11:00         ` amit daniel kachhap
2014-06-19 10:21 ` Tomasz Figa
2014-06-19 10:21   ` Tomasz Figa
2014-06-19 16:01   ` Doug Anderson
2014-06-19 16:01     ` Doug Anderson
2014-06-19 16:17     ` Tomasz Figa
2014-06-19 16:17       ` Tomasz Figa
2014-06-19 16:31       ` Doug Anderson
2014-06-19 16:31         ` Doug Anderson
2014-06-19 16:40         ` Tomasz Figa
2014-06-19 16:40           ` Tomasz Figa
2014-06-20  8:15           ` Will Deacon [this message]
2014-06-20  8:15             ` Will Deacon
2014-06-20 11:19             ` amit daniel kachhap
2014-06-20 11:19               ` amit daniel kachhap
2014-06-20 17:47               ` Doug Anderson
2014-06-20 17:47                 ` Doug Anderson
2014-06-21  9:53                 ` amit daniel kachhap
2014-06-21  9:53                   ` amit daniel kachhap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140620081509.GA25104@arm.com \
    --to=will.deacon@arm.com \
    --cc=Jonathan.Austin@arm.com \
    --cc=amit.daniel@samsung.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=davidriley@chromium.org \
    --cc=dianders@chromium.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.