All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
To: Bruce Richardson
	<bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3] EAL: fix usage of printf-like functions
Date: Fri, 20 Jun 2014 16:58:03 -0700	[thread overview]
Message-ID: <20140620165803.71f68c43@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1403307270-28308-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Sat, 21 Jun 2014 00:34:30 +0100
Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:

> +			(int)(strnlen(buf, sizeof(buf)) - sizeof("_config")),

minor nit, paren not needed here
			(int)strnlen(buf, sizeof...)

better yet change rte_snprintf() to take a size_t to make it compatiable with snprintf

  parent reply	other threads:[~2014-06-20 23:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 18:42 [PATCH] EAL: add format(printf) attrib. to appropriate fns Bruce Richardson
     [not found] ` <1403030562-25820-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-19  8:37   ` Thomas Monjalon
2014-06-19 18:21     ` [PATCH v2] EAL: fix usage of printf-like functions Bruce Richardson
     [not found]       ` <1403202092-12384-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-20  8:24         ` De Lara Guarch, Pablo
     [not found]           ` <E115CCD9D858EF4F90C690B0DCB4D897082CC6E5-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-20 23:34             ` [PATCH v3] " Bruce Richardson
     [not found]               ` <1403307270-28308-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-20 23:58                 ` Stephen Hemminger [this message]
     [not found]                   ` <20140620165803.71f68c43-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-21  0:02                     ` Richardson, Bruce
2014-06-27  0:48                 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140620165803.71f68c43@nehalam.linuxnetplumber.net \
    --to=stephen-otpzqlsittunbdjkjebofr2eb7je58tq@public.gmane.org \
    --cc=bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.