From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Dave Hansen <dave@sr71.net>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [RFC][PATCH 3/3] x86: make MP a required-feature on 64-bit
Date: Fri, 20 Jun 2014 20:15:18 +0200 [thread overview]
Message-ID: <20140620181518.GG11391@pd.tnic> (raw)
In-Reply-To: <53A47461.4050409@zytor.com>
On Fri, Jun 20, 2014 at 10:50:25AM -0700, H. Peter Anvin wrote:
> Looking at the AMD init code, there is a whole bunch of other 32/64-bit
> differences that are clearly bogus. I also see that amd_k7_smp_check()
> doesn't even *exist* on 64 bits, and that init_amd_k7() which calls
> amd_k7_smp_check() only is ever called for family == 6, despite having
> tests for family 7 and above in it.
No, K7 is family 6. The tests are for c->x86_model, or am I looking at
the wrong place?
OTOH, init_amd() could probably use a cleanup of moving the per-family
code into init_amd_<fam>() functions and extending the switch-case.
I'll take a look.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-06-20 18:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 16:17 [RFC][PATCH 1/3] x86: introduce disabled-features Dave Hansen
2014-06-20 16:17 ` [RFC][PATCH 2/3] x86: add more disabled features Dave Hansen
2014-06-20 16:17 ` [RFC][PATCH 3/3] x86: make MP a required-feature on 64-bit Dave Hansen
2014-06-20 16:23 ` H. Peter Anvin
2014-06-20 16:30 ` Dave Hansen
2014-06-20 16:37 ` H. Peter Anvin
2014-06-20 17:43 ` Borislav Petkov
2014-06-20 17:47 ` H. Peter Anvin
2014-06-20 18:05 ` Borislav Petkov
2014-06-20 18:16 ` Dave Jones
2014-06-20 18:48 ` Borislav Petkov
2014-06-20 18:54 ` H. Peter Anvin
2014-06-20 20:00 ` Borislav Petkov
2014-06-20 20:22 ` H. Peter Anvin
2014-06-20 20:35 ` Borislav Petkov
2014-06-20 17:50 ` H. Peter Anvin
2014-06-20 18:15 ` Borislav Petkov [this message]
2014-06-20 18:57 ` H. Peter Anvin
2014-06-20 20:37 ` Borislav Petkov
2014-06-23 6:11 ` Andi Kleen
2014-06-20 16:20 ` [RFC][PATCH 1/3] x86: introduce disabled-features H. Peter Anvin
2014-06-20 17:20 ` Dave Hansen
2014-06-20 20:40 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620181518.GG11391@pd.tnic \
--to=bp@alien8.de \
--cc=ak@linux.intel.com \
--cc=dave@sr71.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.