All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: devel@driverdev.osuosl.org, Jiri Kosina <trivial@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if
Date: Fri, 20 Jun 2014 13:40:27 -0700	[thread overview]
Message-ID: <20140620204027.GC16973@kroah.com> (raw)
In-Reply-To: <87simz49ie.fsf@rasmusvillemoes.dk>

On Fri, Jun 20, 2014 at 10:21:45PM +0200, Rasmus Villemoes wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> 
> > On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
> >> All of the code is #if 0'd out, and the change just replaces a
> >> space with a newline, so this obviously doesn't change anything.
> >
> > How about just deleting all the #if 0 code out entirely so no one has to
> > worry about it anymore?
> 
> Fine by me. Like this?
> 
> From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> Subject: [PATCH] drivers/staging/rtl8821ae/rtl8821ae: Remove dead code
> 
> This is all #if 0'ed out, and it contains some rather weird stuff
> (post-increment of a bool, for example). Nuke it.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Looks good, if you send it in a stand-along email, I can even apply it
:)

thanks,

greg k-h

      reply	other threads:[~2014-06-20 20:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 19:56 [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if Rasmus Villemoes
2014-06-20 20:07 ` Greg Kroah-Hartman
2014-06-20 20:21   ` Rasmus Villemoes
2014-06-20 20:40     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140620204027.GC16973@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.