From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758020AbaFTUg1 (ORCPT ); Fri, 20 Jun 2014 16:36:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60946 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbaFTUg0 (ORCPT ); Fri, 20 Jun 2014 16:36:26 -0400 Date: Fri, 20 Jun 2014 13:40:27 -0700 From: Greg Kroah-Hartman To: Rasmus Villemoes Cc: devel@driverdev.osuosl.org, Jiri Kosina , linux-kernel@vger.kernel.org Subject: Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if Message-ID: <20140620204027.GC16973@kroah.com> References: <1403294195-18209-1-git-send-email-linux@rasmusvillemoes.dk> <20140620200707.GA16329@kroah.com> <87simz49ie.fsf@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87simz49ie.fsf@rasmusvillemoes.dk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 20, 2014 at 10:21:45PM +0200, Rasmus Villemoes wrote: > Greg Kroah-Hartman writes: > > > On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote: > >> All of the code is #if 0'd out, and the change just replaces a > >> space with a newline, so this obviously doesn't change anything. > > > > How about just deleting all the #if 0 code out entirely so no one has to > > worry about it anymore? > > Fine by me. Like this? > > From: Rasmus Villemoes > Subject: [PATCH] drivers/staging/rtl8821ae/rtl8821ae: Remove dead code > > This is all #if 0'ed out, and it contains some rather weird stuff > (post-increment of a bool, for example). Nuke it. > > Signed-off-by: Rasmus Villemoes Looks good, if you send it in a stand-along email, I can even apply it :) thanks, greg k-h