From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>, Ian Kent <raven@themaw.net>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Thorsten Diehl <thorsten.diehl@de.ibm.com>,
Andrea Righi <andrea@betterlinux.com>,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Stefan Bader <stefan.bader@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] /proc/stat vs. failed order-4 allocation
Date: Sat, 21 Jun 2014 11:10:58 +0200 [thread overview]
Message-ID: <20140621091058.GC3463@osiris> (raw)
In-Reply-To: <20140618142931.857d57fe0007a361404f6cab@linux-foundation.org>
On Wed, Jun 18, 2014 at 02:29:31PM -0700, Andrew Morton wrote:
> On Mon, 16 Jun 2014 11:04:50 +0200 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
> > These two patches are supposed to "fix" failed order-4 memory
> > allocations which have been observed when reading /proc/stat.
> > The problem has been observed on s390 as well as on x86.
> >
> > To address the problem change the seq_file memory allocations to
> > fallback to use vmalloc, so that allocations also work if memory
> > is fragmented.
> >
> > This approach seems to be simpler and less intrusive than changing
> > /proc/stat to use an interator. Also it "fixes" other users as well,
> > which use seq_file's single_open() interface.
>
> Yes, those changes look pretty simple and effective.
>
> I'm unclear on how urgent these fixes are. I semi-randomly tagged them
> for 3.16 with a -stable backport, but that could be changed?
I assume tagged for 3.16 means you intend to get it merged before 3.16
gets released?
If so, then that would be fine with me.
next prev parent reply other threads:[~2014-06-21 9:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 9:04 [PATCH 0/2] /proc/stat vs. failed order-4 allocation Heiko Carstens
2014-06-16 9:04 ` [PATCH 1/2] proc/stat: convert to single_open_size() Heiko Carstens
2014-06-18 23:28 ` David Rientjes
2014-06-16 9:04 ` [PATCH 2/2] fs/seq_file: fallback to vmalloc allocation Heiko Carstens
2014-06-18 23:31 ` David Rientjes
2014-06-18 21:29 ` [PATCH 0/2] /proc/stat vs. failed order-4 allocation Andrew Morton
2014-06-21 9:10 ` Heiko Carstens [this message]
2014-06-23 23:04 ` Andrew Morton
2014-06-24 23:52 ` David Rientjes
2014-06-25 6:15 ` Heiko Carstens
2014-06-26 2:20 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140621091058.GC3463@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andrea@betterlinux.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=rientjes@google.com \
--cc=stefan.bader@canonical.com \
--cc=thorsten.diehl@de.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.