From: Mark Brown <broonie@kernel.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: peter.ujfalusi@ti.com, liam.r.girdwood@linux.intel.com,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
detheridge@ti.com
Subject: Re: [PATCH 2/2] ASoC: davinci-mcasp: Allow best effort in selecting BCLK divider
Date: Sat, 21 Jun 2014 11:04:52 +0100 [thread overview]
Message-ID: <20140621100452.GA5099@sirena.org.uk> (raw)
In-Reply-To: <6f645a7d31219c4410db31030a3ab07a4af6ae0e.1402652359.git.jsarha@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 426 bytes --]
On Fri, Jun 13, 2014 at 12:50:00PM +0300, Jyri Sarha wrote:
> Do not fail if the exact BLCK rate can not be produced, just print a
> warning. Check that sysclk frequency is set before implicitly setting
> the BCLK divider.
I've appled this but not as a fix - it's kind of on the edge if we
should be doing this at all, it's helpful for interoperability but
getting an inexact frequency obviously impacts the resulting audio.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-06-21 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 9:49 [PATCH 0/2] Couple of fixes to davinci-mcasp driver Jyri Sarha
2014-06-13 9:49 ` [PATCH 1/2] ASoC: davinci-mcasp: Add dependecy to SND_DAVINCI_SOC or SND_OMAP_SOC Jyri Sarha
2014-06-21 10:03 ` Mark Brown
2014-06-13 9:50 ` [PATCH 2/2] ASoC: davinci-mcasp: Allow best effort in selecting BCLK divider Jyri Sarha
2014-06-21 10:04 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140621100452.GA5099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=detheridge@ti.com \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.