From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyRut-0005pC-0k for qemu-devel@nongnu.org; Sat, 21 Jun 2014 16:29:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WyRup-0001Xm-Fn for qemu-devel@nongnu.org; Sat, 21 Jun 2014 16:29:38 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:56178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyRup-0001XX-9q for qemu-devel@nongnu.org; Sat, 21 Jun 2014 16:29:35 -0400 Date: Sat, 21 Jun 2014 22:29:33 +0200 From: Aurelien Jarno Message-ID: <20140621202933.GC27000@hall.aurel32.net> References: <1403379331-14433-1-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Sat, Jun 21, 2014 at 09:06:21PM +0100, Peter Maydell wrote: > On 21 June 2014 20:35, Aurelien Jarno wrote: > > The roundAndPackFloat16 function should return a float16 value, not a > > float32 one. Fix that. > > > > Cc: Peter Maydell > > Signed-off-by: Aurelien Jarno > > Agreed, though I don't think it has any effect on the results. No, it doesn't have any effect on the results, but it produces slightly less optimized code. The main problem there is that it fails to build when enforcing type checking, though less and less targets are compiling when it is enabled. > Can we have the usual "ok under softfloat 2a or 2b license" > confirmation, please? Yes, I am fine to license this patch under softfloat 2a or 2b license. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net