From: Johannes Weiner <hannes@cmpxchg.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
kbuild-all@01.org
Subject: Re: [mmotm:master 131/230] kernel/events/uprobes.c:330:1: warning: label 'put_new' defined but not used
Date: Sun, 22 Jun 2014 21:18:03 -0400 [thread overview]
Message-ID: <20140623011803.GL7331@cmpxchg.org> (raw)
In-Reply-To: <20140620025800.GA20022@localhost>
On Fri, Jun 20, 2014 at 10:58:00AM +0800, Fengguang Wu wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: df25ba7db0775d87018e2cd92f26b9b087093840
> commit: 9e458f8e3d973f459b8c8fef50e15012764f7998 [131/230] mm-memcontrol-rewrite-charge-api-fix
> config: make ARCH=i386 allyesconfig
>
> All warnings:
>
> kernel/events/uprobes.c: In function 'uprobe_write_opcode':
> >> kernel/events/uprobes.c:330:1: warning: label 'put_new' defined but not used [-Wunused-label]
> put_new:
> ^
>
> vim +/put_new +330 kernel/events/uprobes.c
>
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 314 ret = -ENOMEM;
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 315 new_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vaddr);
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 316 if (!new_page)
> 9f92448c kernel/events/uprobes.c Oleg Nesterov 2012-07-29 317 goto put_old;
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 318
> 9e458f8e kernel/events/uprobes.c Andrew Morton 2014-06-20 319 // if (mem_cgroup_charge_anon(new_page, mm, GFP_KERNEL))
> 9e458f8e kernel/events/uprobes.c Andrew Morton 2014-06-20 320 // goto put_new;
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 321
> 29dedee0 kernel/events/uprobes.c Oleg Nesterov 2014-05-05 322 __SetPageUptodate(new_page);
> 3f47107c kernel/events/uprobes.c Oleg Nesterov 2013-03-24 323 copy_highpage(new_page, old_page);
> 3f47107c kernel/events/uprobes.c Oleg Nesterov 2013-03-24 324 copy_to_page(new_page, vaddr, &opcode, UPROBE_SWBP_INSN_SIZE);
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 325
> c517ee74 kernel/events/uprobes.c Oleg Nesterov 2012-07-29 326 ret = __replace_page(vma, vaddr, old_page, new_page);
> 29dedee0 kernel/events/uprobes.c Oleg Nesterov 2014-05-05 327 if (ret)
> 29dedee0 kernel/events/uprobes.c Oleg Nesterov 2014-05-05 328 mem_cgroup_uncharge_page(new_page);
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 329
> 9f92448c kernel/events/uprobes.c Oleg Nesterov 2012-07-29 @330 put_new:
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 331 page_cache_release(new_page);
> 9f92448c kernel/events/uprobes.c Oleg Nesterov 2012-07-29 332 put_old:
> 7b2d81d4 kernel/uprobes.c Ingo Molnar 2012-02-17 333 put_page(old_page);
> 7b2d81d4 kernel/uprobes.c Ingo Molnar 2012-02-17 334
> 5323ce71 kernel/events/uprobes.c Oleg Nesterov 2012-06-15 335 if (unlikely(ret == -EAGAIN))
> 5323ce71 kernel/events/uprobes.c Oleg Nesterov 2012-06-15 336 goto retry;
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 337 return ret;
> 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 338 }
This one is also fixed with the replacement patch that switches
uprobes over to the new memcg charge API.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-06-23 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53a39bf2./ABA70PSoAso2CXo%fengguang.wu@intel.com>
2014-06-20 2:58 ` [mmotm:master 131/230] kernel/events/uprobes.c:330:1: warning: label 'put_new' defined but not used Fengguang Wu
2014-06-23 1:18 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623011803.GL7331@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.