From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] thor: cosmetic: Update the cmd_thordown help message to present example usage
Date: Mon, 23 Jun 2014 09:01:05 +0200 [thread overview]
Message-ID: <20140623090105.3f254322@amdc2363> (raw)
In-Reply-To: <53A45A58.8090600@wwwdotorg.org>
Hi Stephen,
> On 06/20/2014 01:35 AM, Lukasz Majewski wrote:
>
> > diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c
>
> > U_BOOT_CMD(thordown, CONFIG_SYS_MAXARGS, 1, do_thor_down,
> > "TIZEN \"THOR\" downloader",
> > - "<USB_controller> <interface> <dev>\n"
> > + "<USB_controller> <interface> <dev> e.g. thor 0 mmc 0\n"
> > " - device software upgrade via LTHOR TIZEN dowload\n"
> > " program via <USB_controller> on device <dev>,\n"
> > " attached to interface <interface>\n"
>
> I couldn't find any examples of other commands which do this. Rathe
> than add the "e.g." text, perhaps just add the word "thor" at the
> start of the command parameter list. That's much more common in
> existing commands:
>
> - "<USB_controller> <interface> <dev>\n"
> + "thor <USB_controller> <interface> <dev>\n"
>
Ok. Thanks.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2014-06-23 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 7:35 [U-Boot] [PATCH] thor: cosmetic: Update the cmd_thordown help message to present example usage Lukasz Majewski
2014-06-20 15:59 ` Stephen Warren
2014-06-23 7:01 ` Lukasz Majewski [this message]
2014-06-23 7:35 ` [U-Boot] [PATCH v2] " Lukasz Majewski
2014-06-23 8:37 ` Marek Vasut
2014-06-23 9:50 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623090105.3f254322@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.