From: Andi Kleen <ak@linux.intel.com>
To: Oren Twaig <oren@scalemp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
David Rientjes <rientjes@google.com>,
Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
Richard Weinberger <richard@nod.at>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Shai Fultheim <shai@scalemp.com>
Subject: Re: [PATCH] x86, vsmp: Remove is_vsmp_box() from apic_is_clustered_box()
Date: Mon, 23 Jun 2014 07:18:03 -0700 [thread overview]
Message-ID: <20140623141803.GC8178@tassilo.jf.intel.com> (raw)
In-Reply-To: <53A7BC92.3080307@scalemp.com>
On Mon, Jun 23, 2014 at 08:35:14AM +0300, Oren Twaig wrote:
> Remove invalid code which caused TSC to be declared as "unstable" on vSMP
> Foundation box even if it was stable and let the kernel decide for itself.
>
> When a vSMP Foundation box is detected, the function apic_cluster_num() counts
> the number of APIC clusters found. If more than one found, a multi board
> configuration is assumed, and TSC marked as unstable. This behavior is
> incorrect as vSMP Foundation may use processors from single node only, attached
> to memory of other nodes - and such node may have more than one APIC cluster
> (typically any recent intel box has more than single APIC_CLUSTERID(x)).
>
> To fix this, we simply remove the code which detects a vSMP Foundation box and
> affects apic_is_clusted_box() return value. This can be done because later the
> kernel checks by itself if the TSC is stable using the
> check_tsc_sync_[source|target]() functions and marks TSC as unstable if needed.
Looks good to me. Yes the APIC cluster check is obsolete.
-andi
next prev parent reply other threads:[~2014-06-23 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 5:35 [PATCH] x86, vsmp: Remove is_vsmp_box() from apic_is_clustered_box() Oren Twaig
2014-06-23 14:18 ` Andi Kleen [this message]
2014-06-27 5:05 ` Oren Twaig
2014-06-27 5:39 ` H. Peter Anvin
2014-06-29 10:07 ` Oren Twaig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623141803.GC8178@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oren@scalemp.com \
--cc=paul.gortmaker@windriver.com \
--cc=richard@nod.at \
--cc=rientjes@google.com \
--cc=shai@scalemp.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yoshihiro.yunomae.ez@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.