From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] arm: imx6: move imx6_init_lowlevel to single initcall
Date: Tue, 24 Jun 2014 09:17:49 +0200 [thread overview]
Message-ID: <20140624071749.GD15686@pengutronix.de> (raw)
In-Reply-To: <1403591596-13955-1-git-send-email-dev@lynxeye.de>
On Tue, Jun 24, 2014 at 08:33:14AM +0200, Lucas Stach wrote:
> Instead of repeating the same lowlevel init for every board
> move it to it's own initcall.
>
> Avoids code bloat and shaves off almost 1.5kB of uncompressed
> barebox size for a default imx_v7_defconfig build.
>
> For boards wherethe hostname setup was done in the postcore
> initcall we move this to a device initcall to get it out of
> the way.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
You could also call imx6_init_lowlevel from imx6_init which is also
called at postcore_initcall time.
At the moment are boards are free to:
- replace imx6_init_lowlevel with their own version
- Call imx6_init_lowlevel earlier
I hope we won't regret this change when we get some special board.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-06-24 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 6:33 [PATCH 1/3] arm: imx6: move imx6_init_lowlevel to single initcall Lucas Stach
2014-06-24 6:33 ` [PATCH 2/3] arm: imx6: rename hummingboard directory to microsom Lucas Stach
2014-06-24 6:33 ` [PATCH 3/3] scripts: tegra: add gitignore Lucas Stach
2014-06-24 7:17 ` Sascha Hauer [this message]
2014-06-26 12:02 ` [PATCH 1/3] arm: imx6: move imx6_init_lowlevel to single initcall Holger Schurig
2014-06-26 20:51 ` Sascha Hauer
2014-06-27 9:08 ` Holger Schurig
2014-07-01 6:42 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624071749.GD15686@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.