From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] sched/idle: Drop !! while calculating 'broadcast'
Date: Tue, 24 Jun 2014 10:03:47 +0200 [thread overview]
Message-ID: <20140624080347.GL13930@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <0dfbe2976aa108c53e08d3477ea90f6360c1f54c.1403584026.git.viresh.kumar@linaro.org>
On Tue, Jun 24, 2014 at 10:01:01AM +0530, Viresh Kumar wrote:
> We don't need 'broadcast' to be set to 'zero or one', but to 'zero or non-zero'
> and so the extra operation to convert it to 'zero or one' can be skipped.
>
> Also change type of 'broadcast' to unsigned int, i.e. type of
> drv->states[*].flags.
All true; but does it change anything? That is, does your compiler
generate better code because of this?
next prev parent reply other threads:[~2014-06-24 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 4:31 [PATCH] sched/idle: Drop !! while calculating 'broadcast' Viresh Kumar
2014-06-24 8:03 ` Peter Zijlstra [this message]
2014-06-24 10:48 ` Viresh Kumar
2014-06-24 12:18 ` Mike Galbraith
2014-06-24 12:35 ` Viresh Kumar
2014-07-05 10:43 ` [tip:sched/core] sched/idle: Drop !! while calculating 'broadcast ' tip-bot for Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624080347.GL13930@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.