From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 02/10] mfd: cros_ec: Allow static din/dout buffers with cros_ec_register() Date: Tue, 24 Jun 2014 11:16:45 +0100 Message-ID: <20140624101645.GG13803@lee--X1> References: <1403115247-8853-1-git-send-email-dianders@chromium.org> <1403115247-8853-3-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f182.google.com ([209.85.223.182]:46216 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbaFXKQw (ORCPT ); Tue, 24 Jun 2014 06:16:52 -0400 Received: by mail-ie0-f182.google.com with SMTP id rp18so46217iec.41 for ; Tue, 24 Jun 2014 03:16:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1403115247-8853-3-git-send-email-dianders@chromium.org> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Doug Anderson Cc: Andrew Bresticker , swarren@wwwdotorg.org, olof@lixom.net, Sonny Rao , linux-samsung-soc@vger.kernel.org, Javier Martinez Canillas , Bill Richardson , sjg@chromium.org, Wolfram Sang , broonie@kernel.org, sameo@linux.intel.com, linux-kernel@vger.kernel.org On Wed, 18 Jun 2014, Doug Anderson wrote: > From: Bill Richardson >=20 > The lower-level driver may want to provide its own buffers. If so, > there's no need to allocate new ones. This already happens to work > just fine (since we check for size of 0 and use devm allocation), but > it's good to document it. >=20 > [dianders: Resolved conflicts; documented that no code changes needed > on mainline] >=20 > Signed-off-by: Bill Richardson > Signed-off-by: Doug Anderson > Reviewed-by: Simon Glass > --- > Changes in v2: None >=20 > include/linux/mfd/cros_ec.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Lee Jones > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.= h > index 7e9fe6e..2ee3190 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -68,8 +68,8 @@ struct cros_ec_msg { > * We use this alignment to keep ARM and x86 happy. Probably word > * alignment would be OK, there might be a small performance advanta= ge > * to using dword. > - * @din_size: size of din buffer > - * @dout_size: size of dout buffer > + * @din_size: size of din buffer to allocate (zero to use static din= ) > + * @dout_size: size of dout buffer to allocate (zero to use static d= out) > * @command_send: send a command > * @command_recv: receive a command > * @ec_name: name of EC device (e.g. 'chromeos-ec') --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog