From: Cyril Hrubis <metan-+ZI9xUNit7I@public.gmane.org>
To: "Michael Kerrisk (man-pages)"
<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] vmsplice.2: vmsplice() does not fail on nr_segs=0
Date: Wed, 25 Jun 2014 16:12:35 +0200 [thread overview]
Message-ID: <20140625141235.GA10090@rei.Home> (raw)
This case is no-op and no error is returned.
See fs/splice.c vmsplice syscall which contains:
if (unlikely(nr_segs > UIO_MAXIOV))
return -EINVAL;
else if (unlikely(!nr_segs))
return 0;
and looking at the git log suggests that this snipped was always there.
Signed-off-by: Cyril Hrubis <chrubis-AlSwsSmVLrQ@public.gmane.org>
---
man2/vmsplice.2 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man2/vmsplice.2 b/man2/vmsplice.2
index 35ab07f..a9ad786 100644
--- a/man2/vmsplice.2
+++ b/man2/vmsplice.2
@@ -133,7 +133,7 @@ either not valid, or doesn't refer to a pipe.
.TP
.B EINVAL
.I nr_segs
-is 0 or greater than
+is greater than
.BR IOV_MAX ;
or memory not aligned if
.B SPLICE_F_GIFT
--
1.8.5.5
--
Cyril Hrubis
chrubis-AlSwsSmVLrQ@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2014-06-25 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 14:12 Cyril Hrubis [this message]
[not found] ` <20140625141235.GA10090-HSzIOc4LzcM@public.gmane.org>
2014-07-14 12:57 ` [PATCH] vmsplice.2: vmsplice() does not fail on nr_segs=0 chrubis-AlSwsSmVLrQ
2014-08-26 8:42 ` chrubis-AlSwsSmVLrQ
[not found] ` <20140826084242.GA25225-J5syqNJeCN7twjQa/ONI9g@public.gmane.org>
2014-09-30 12:46 ` chrubis-AlSwsSmVLrQ
2014-10-01 11:23 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625141235.GA10090@rei.Home \
--to=metan-+zi9xunit7i@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.