From: Arnd Bergmann <arnd@arndb.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] video: clps711x: Add new Cirrus Logic CLPS711X framebuffer driver
Date: Wed, 25 Jun 2014 12:26:10 +0000 [thread overview]
Message-ID: <201406251426.11130.arnd@arndb.de> (raw)
In-Reply-To: <1403194843-32574-1-git-send-email-shc_work@mail.ru>
On Thursday 19 June 2014, Alexander Shiyan wrote:
> -config FB_CLPS711X
> - bool "CLPS711X LCD support"
> - depends on (FB = y) && ARM && ARCH_CLPS711X
> +config FB_CLPS711X_OLD
> + bool
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> +
> +config FB_CLPS711X
> + tristate "CLPS711X LCD support"
> + depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
> + select FB_CLPS711X_OLD if ARCH_CLPS711X && !ARCH_MULTIPLATFORM
> + select BACKLIGHT_LCD_SUPPORT
> + select FB_MODE_HELPERS
I found that with this change, you can now end up in a situation of CONFIG_FB=m
and FB_CLPS711X=y, which doesn't link properly.
We need to either turn FB_CLPS711X_OLD into 'tristate' or add
'depends on ARCH_MULTIPLATFORM || FB=y' to FB_CLPS711X.
Arnd
prev parent reply other threads:[~2014-06-25 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 16:20 [PATCH v2 1/2] video: clps711x: Add new Cirrus Logic CLPS711X framebuffer driver Alexander Shiyan
2014-06-23 10:58 ` Tomi Valkeinen
2014-06-25 12:26 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201406251426.11130.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.