All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Christoph Hellwig <hch@lst.de>, Micky Ching <micky_ching@realsil.com.cn>
Cc: Hannes Reinecke <hare@suse.de>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [hch-scsi-queue:core-for-3.17 18/27] drivers/staging/rts5208/rtsx.c:468:5: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64'
Date: Thu, 26 Jun 2014 00:23:22 +0800	[thread overview]
Message-ID: <20140625162322.GA8121@localhost> (raw)
In-Reply-To: <20140625154140.GA16179@lst.de>

Hi Christoph,

On Wed, Jun 25, 2014 at 05:41:40PM +0200, Christoph Hellwig wrote:
> Fengguang,
> 
> can you change the kbuild robot to only send warnings in the staging
> drivers to the maintainers of those, and not people changing core code?

The rule is currently CC the first bad commit's author and committer.
In this case,

        commit 4184a1e415257e3d2e75a5adf184de9ffaf82a7c
        Author:     Hannes Reinecke <hare@suse.de>
        AuthorDate: Wed Jun 25 15:27:36 2014 +0200
        Commit:     Christoph Hellwig <hch@lst.de>
        CommitDate: Wed Jun 25 16:21:45 2014 +0200

            scsi: use 64-bit LUNs

=>

        TO: Hannes Reinecke <hare@suse.de>
        CC: Christoph Hellwig <hch@lst.de>

Do you mean adding rule

        if error_file =~ /drivers\/staging/
                TO/CC error_file's author/committer instead
        end

In this case,

        TO: Micky Ching <micky_ching@realsil.com.cn>
        CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I agree that it'd be good for Micky to work out a fix for his staging
driver. However due to the obvious dependency here, it looks best for
you to include the fix together with "scsi: use 64-bit LUNs"?

So in general it'd be good to keep all relevant people in the CC list.
That is,

        TO/CC first bad commit's author/committer
        for each error_file =~ /drivers\/staging/
                CC error_file's author/committer
        end

Thanks,
Fengguang

  reply	other threads:[~2014-06-25 16:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <53aaebe2.SHsdePtLmXw5IHwp%fengguang.wu@intel.com>
2014-06-25 15:41 ` [hch-scsi-queue:core-for-3.17 18/27] drivers/staging/rts5208/rtsx.c:468:5: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64' Christoph Hellwig
2014-06-25 16:23   ` Fengguang Wu [this message]
2014-06-25 17:01     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140625162322.GA8121@localhost \
    --to=fengguang.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=micky_ching@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.