From: Nils Steinger <git@n-st.de>
To: David Sterba <dsterba@suse.cz>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: Add uninstall targets to Makefiles.
Date: Wed, 25 Jun 2014 21:40:40 +0200 [thread overview]
Message-ID: <20140625194040.GA8631@ny.voidptr.de> (raw)
In-Reply-To: <20140623150442.GK1553@twin.jikos.cz>
On Mon, Jun 23, 2014 at 05:04:42PM +0200, David Sterba wrote:
> On Mon, Jun 23, 2014 at 04:23:48AM +0200, Nils Steinger wrote:
> > + rmdir -p --ignore-fail-on-non-empty $(DESTDIR)$(man8dir)
>
> > + rmdir -p --ignore-fail-on-non-empty $(DESTDIR)$(libdir)
>
> > + rmdir -p --ignore-fail-on-non-empty $(DESTDIR)$(bindir)
>
> I don't think it's right to remove the systemwide directories: bindir,
> libdir and man8dir. There rest are btrfs subdirs (eg. incdir), that's
> fine.
On my system, man8dir didn't exist prior to the installation, so I
thought it would be reasonable to have the uninstallation routine remove
it. bindir and libdir will exist by default on most systems, so that's a
different case…
So, should we really keep the directories around, even if they were
created by the installation and are now empty (if they aren't, they
won't be removed anyway)?
next prev parent reply other threads:[~2014-06-25 19:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 19:48 [PATCH] btrfs-progs: Add uninstall targets to Makefiles Nils Steinger
2014-06-20 19:48 ` Nils Steinger
2014-06-23 1:57 ` Satoru Takeuchi
2014-06-23 2:23 ` [PATCH v2] " Nils Steinger
2014-06-23 2:33 ` Satoru Takeuchi
2014-06-23 15:04 ` David Sterba
2014-06-25 19:40 ` Nils Steinger [this message]
2014-06-27 12:32 ` David Sterba
2014-07-25 13:41 ` [PATCH v3] " n.st
2014-07-25 13:48 ` [PATCH v2] " Nils Steinger
2014-08-14 19:36 ` [PATCH v3] " Nils Steinger
-- strict thread matches above, loose matches on Subject: below --
2014-08-14 19:36 Nils Steinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625194040.GA8631@ny.voidptr.de \
--to=git@n-st.de \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.