From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Roger Quadros <rogerq@ti.com>,
rnayak@ti.com, balbi@ti.com, nsekhar@ti.com, kishon@ti.com,
george.cherian@ti.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: DRA7-evm: Enable SATA PHY and USB PHY power supplies
Date: Thu, 26 Jun 2014 00:31:16 -0700 [thread overview]
Message-ID: <20140626073115.GD28884@atomide.com> (raw)
In-Reply-To: <53AB4CE0.6020705@ti.com>
* Nishanth Menon <nm@ti.com> [140625 15:29]:
> On 06/25/2014 07:56 AM, Roger Quadros wrote:
> > The SATA and USB PHYs need the 1.8V and 3.3V supplies.
> > The PHY drivers/framework don't yet support regulator
> > supply so we have to keep these regulators always-on till
> > then.
> >
> > Signed-off-by: Roger Quadros <rogerq@ti.com>
> > ---
> > arch/arm/boot/dts/dra7-evm.dts | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
> > index 4adc280..99a1f79 100644
> > --- a/arch/arm/boot/dts/dra7-evm.dts
> > +++ b/arch/arm/boot/dts/dra7-evm.dts
> > @@ -241,6 +241,7 @@
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > regulator-boot-on;
> > + regulator-always-on;
> > };
> >
> > ldo9_reg: ldo9 {
> > @@ -266,6 +267,7 @@
> > regulator-min-microvolt = <3300000>;
> > regulator-max-microvolt = <3300000>;
> > regulator-boot-on;
> > + regulator-always-on;
> > };
> > };
> > };
> >
>
> Why not fix phy driver/framework as needed? the trouble is people
> always forget to remove always-on... who actually audits old logs and
> fixes stuff back up?
Yes I agree let's not play with the regulator-always-on unless
absolutely necessary.
Regards,
Tony
next prev parent reply other threads:[~2014-06-26 7:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 12:56 [PATCH] ARM: DRA7-evm: Enable SATA PHY and USB PHY power supplies Roger Quadros
2014-06-25 12:56 ` Roger Quadros
2014-06-25 22:27 ` Nishanth Menon
2014-06-25 22:27 ` Nishanth Menon
2014-06-26 7:31 ` Tony Lindgren [this message]
2014-06-26 9:36 ` Roger Quadros
2014-06-26 9:36 ` Roger Quadros
2014-06-26 14:22 ` Roger Quadros
2014-06-26 14:22 ` Roger Quadros
2014-06-26 15:06 ` Tero Kristo
2014-06-26 15:06 ` Tero Kristo
2014-06-30 7:55 ` Roger Quadros
2014-06-30 7:55 ` Roger Quadros
2014-07-02 11:51 ` Roger Quadros
2014-07-02 11:51 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626073115.GD28884@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=rnayak@ti.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.