From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Kirill Tkhai <ktkhai@parallels.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
tkhai@yandex.ru, Mike Galbraith <umgwanakikbuti@gmail.com>,
khorenko@parallels.com, Ben Segall <bsegall@google.com>,
Paul Turner <pjt@google.com>
Subject: Re: [PATCH v3 3/3] sched: Rework check_for_tasks()
Date: Thu, 26 Jun 2014 17:00:42 +0530 [thread overview]
Message-ID: <20140626113041.GD20048@linux.vnet.ibm.com> (raw)
In-Reply-To: <1403684395.3462.44.camel@tkhai>
* Kirill Tkhai <ktkhai@parallels.com> [2014-06-25 12:19:55]:
>
> 1)Iterate thru all of threads in the system.
> Check for all threads, not only for group leaders.
>
> 2)Check for p->on_rq instead of p->state and cputime.
> Preempted task in !TASK_RUNNING state OR just
> created task may be queued, that we want to be
> reported too.
>
> 3)Use read_lock() instead of write_lock().
> This function does not change any structures, and
> read_lock() is enough.
>
> Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
> CC: Konstantin Khorenko <khorenko@parallels.com>
> CC: Ben Segall <bsegall@google.com>
> CC: Paul Turner <pjt@google.com>
> CC: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> CC: Mike Galbraith <umgwanakikbuti@gmail.com>
> CC: Peter Zijlstra <peterz@infradead.org>
> CC: Ingo Molnar <mingo@kernel.org>
> ---
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2014-06-26 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140625081502.2861.12526.stgit@tkhai>
2014-06-25 8:19 ` [PATCH v3 1/3] sched/fair: Disable runtime_enabled on dying rq Kirill Tkhai
2014-06-25 17:57 ` bsegall
2014-07-05 10:45 ` [tip:sched/core] " tip-bot for Kirill Tkhai
2014-06-25 8:19 ` [PATCH v3 2/3] sched/rt: __disable_runtime: Enqueue just unthrottled rt_rq back on the stack Kirill Tkhai
2014-06-26 11:08 ` Srikar Dronamraju
2014-06-26 11:09 ` Srikar Dronamraju
2014-07-05 10:46 ` [tip:sched/core] sched/rt: Enqueue just unthrottled rt_rq back on the stack in __disable_runtime() tip-bot for Kirill Tkhai
2014-06-25 8:19 ` [PATCH v3 3/3] sched: Rework check_for_tasks() Kirill Tkhai
2014-06-26 11:30 ` Srikar Dronamraju [this message]
2014-07-05 10:46 ` [tip:sched/core] " tip-bot for Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626113041.GD20048@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=bsegall@google.com \
--cc=khorenko@parallels.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tkhai@yandex.ru \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.