From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Christopher Covington <cov@codeaurora.org>,
Ingo Molnar <mingo@redhat.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Vagin <avagin@openvz.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Vaibhav Nagarnaik <vnagarnaik@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RFC: Add signal command to trace events
Date: Thu, 26 Jun 2014 18:45:16 +0200 [thread overview]
Message-ID: <20140626164516.GA24731@redhat.com> (raw)
In-Reply-To: <20140626162943.GA9970@redhat.com>
On 06/26, Oleg Nesterov wrote:
>
> > > +//ifdef CONFIG_TRACER_SIGNAL
> > > +static void
> > > +signal_trigger(struct event_trigger_data *data)
> > > +{
> > > + force_sig(SIGSTOP, current);
>
> Well, I don't like this. Imho, it would be nice to avoid signals here.
>
> And SIGSTOP in particular. It can interfere with the "real" SIGSTOP
> sent by user, with ptrace, with tty.
And I forgot to mention, note that SIGSTOP stops the whole thread group,
this is not what we want.
> I think we need something else... "STOP" is actually simple, but we need
> some interface which allows to wakeup a task sleeping in TASK_KILLABLE
> after it hits ETT_FREEZE.
Yes...
Oleg.
next prev parent reply other threads:[~2014-06-26 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 13:57 [PATCH] RFC: Add signal command to trace events Christopher Covington
2014-06-26 15:17 ` Steven Rostedt
2014-06-26 16:29 ` Oleg Nesterov
2014-06-26 16:45 ` Oleg Nesterov [this message]
2014-06-26 16:48 ` Steven Rostedt
2014-06-26 17:15 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626164516.GA24731@redhat.com \
--to=oleg@redhat.com \
--cc=avagin@openvz.org \
--cc=cov@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
--cc=vnagarnaik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.