From: Guillaume Morin <guillaume@morinfr.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guillaume Morin <guillaume@morinfr.org>,
Jonathan Cameron <jic23@kernel.org>,
Sachin Kamat <sachin.kamat@linaro.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error
Date: Sat, 28 Jun 2014 04:30:09 +0200 [thread overview]
Message-ID: <20140628023009.GA13273@bender.morinfr.org> (raw)
In-Reply-To: <20140628020935.GA14333@kroah.com>
On 27 Jun 19:09, Greg Kroah-Hartman wrote:
> > v2: add missing Signed-off-by
>
> That doesn't go here.
I guess I am struggling to get git send-email do what I want
> And what checkpatch error did you fix? And are you sure it needs to be
> fixed?
That's what I changed:
$ scripts/checkpatch.pl -f drivers/staging/iio/frequency/ad9850.c
ERROR: Macros with complex values should be enclosed in parenthesis
#24: FILE: drivers/staging/iio/frequency/ad9850.c:24:
+#define value_mask (u16)0xf000
I assumed that if it was reported as an error, it needed to be fixed...
--
Guillaume Morin <guillaume@morinfr.org>
next prev parent reply other threads:[~2014-06-28 2:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 1:46 [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error Guillaume Morin
2014-06-28 2:09 ` Greg Kroah-Hartman
2014-06-28 2:30 ` Guillaume Morin [this message]
2014-06-28 2:37 ` Greg Kroah-Hartman
2014-06-28 3:10 ` Guillaume Morin
2014-06-28 6:35 ` Michael Welling
2014-06-28 7:00 ` Michael Welling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140628023009.GA13273@bender.morinfr.org \
--to=guillaume@morinfr.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.