From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] NVMe: Change nvme_enable_ctrl to set EN and manage CC thru ctrl_config.
Date: Sat, 28 Jun 2014 10:05:05 -0400 [thread overview]
Message-ID: <20140628140505.GW12025@linux.intel.com> (raw)
In-Reply-To: <1403533476-7193-1-git-send-email-daniel.mcleran@intel.com>
On Mon, Jun 23, 2014@08:24:36AM -0600, Dan McLeran wrote:
> @@ -1465,7 +1470,7 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev)
> aqa = nvmeq->q_depth - 1;
> aqa |= aqa << 16;
>
> - dev->ctrl_config = NVME_CC_ENABLE | NVME_CC_CSS_NVM;
> + dev->ctrl_config = NVME_CC_CSS_NVM;
> dev->ctrl_config |= (PAGE_SHIFT - 12) << NVME_CC_MPS_SHIFT;
> dev->ctrl_config |= NVME_CC_ARB_RR | NVME_CC_SHN_NONE;
> dev->ctrl_config |= NVME_CC_IOSQES | NVME_CC_IOCQES;
We also want this, right?
@@ -1512,7 +1512,6 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev
writel(aqa, &dev->bar->aqa);
writeq(nvmeq->sq_dma_addr, &dev->bar->asq);
writeq(nvmeq->cq_dma_addr, &dev->bar->acq);
- writel(dev->ctrl_config, &dev->bar->cc);
result = nvme_enable_ctrl(dev, cap);
if (result)
prev parent reply other threads:[~2014-06-28 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 14:24 [PATCH] NVMe: Change nvme_enable_ctrl to set EN and manage CC thru ctrl_config Dan McLeran
2014-06-28 14:05 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140628140505.GW12025@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.