From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915: Fix some NUM_RING iterators Date: Sat, 28 Jun 2014 08:26:15 -0700 Message-ID: <20140628152615.GC17803@bwidawsk.net> References: <1403906985-11045-1-git-send-email-benjamin.widawsky@intel.com> <20140628062038.GA25660@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 77D636E233 for ; Sat, 28 Jun 2014 08:26:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140628062038.GA25660@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Rodrigo Vivi , Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCBKdW4gMjgsIDIwMTQgYXQgMDc6MjA6MzhBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIEZyaSwgSnVuIDI3LCAyMDE0IGF0IDAzOjIxOjIwUE0gLTA3MDAsIFJvZHJpZ28g Vml2aSB3cm90ZToKPiA+ICAgIFJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPFsxXXJvZHJpZ28u dml2aUBpbnRlbC5jb20+Cj4gPiAKPiA+ICAgIE9uIEZyaSwgSnVuIDI3LCAyMDE0IGF0IDM6MDkg UE0sIEJlbiBXaWRhd3NreQo+ID4gICAgPFsyXWJlbmphbWluLndpZGF3c2t5QGludGVsLmNvbT4g d3JvdGU6Cj4gPiAKPiA+ICAgICAgVGhlcmUgYXJlIHNvbWUgY2FzZXMgaW4gdGhlIGNvZGUgd2hl cmUgd2UgbmVlZCB0byBrbm93IGhvdyBtYW55IHJpbmdzIHRvCj4gPiAgICAgIGl0ZXJhdGUgb3Zl ciwgYnV0IGNhbm5vdCB1c2UgZm9yX2VhY2hfcmluZygpLiBUaGVzZSBhcmUgYWx3YXlzIGVycm9y Cj4gPiAgICAgIGNhc2VzCj4gPiAgICAgIHdoaWNoIGhhcHBlbiBlaXRoZXIgYmVmb3JlIHJpbmcg c2V0dXAsIG9yIGFmdGVyIHJpbmcgdGVhcmRvd24gKG9yCj4gPiAgICAgIHJlc2V0KS4KPiA+IAo+ ID4gICAgICBOb3RlLCBhIE5VTV9SSU5HUyBpc3N1ZSBleGlzdHMgaW4gc2VtYXBob3JlcywgYnV0 IHRoaXMgaXMgZml4ZWQgYnkgdGhlCj4gPiAgICAgIHJlbWFpbmluZyBzZW1hcGhvcmUgcGF0Y2hl cyB3aGljaCBSb2RyaWdvIHdpbGwgcmVzdWJtaXQgc2hvcnRseS4gSSdkCj4gPiAgICAgIHJhdGhl ciBzZWUgdGhvc2UgcGF0Y2hlcyBmb3IgZml4aW5nIHRoZSBwcm9ibGVtIHRoYW4gZml4IGl0IGhl cmUuCj4gPiAKPiA+ICAgICAgSSBmb3VuZCB0aGlzIGluaXRpYWxseSBmb3IgdGhlIEJTRDIgY2Fz ZSB3aGVyZSBvbiB0aGUgc2FtZSBwbGF0Zm9ybSB3ZQo+ID4gICAgICBjYW4gaGF2ZSBkaWZmZXJp bmcgcmluZ3MuIEFGQUlDVCBob3dldmVyIHRoaXMgZWZmZWN0cyBtYW55IHBsYXRmb3Jtcy4KPiA+ IAo+ID4gICAgICBJJ2QgQ0Mgc3RhYmxlIG9uIHRoaXMsIGV4Y2VwdCBJIHRoaW5rIGFsbCB0aGUg aXNzdWVzIGhhdmUgYmVlbiBhcm91bmQKPiA+ICAgICAgZm9yIG11bHRpcGxlIHJlbGVhc2VzIHdp dGhvdXQgYnVnIHJlcG9ydHMuCj4gPiAKPiA+ICAgICAgQ29tcGlsZSB0ZXN0ZWQgb25seSBmb3Ig bm93Lgo+ID4gCj4gPiAgICAgIFNpZ25lZC1vZmYtYnk6IEJlbiBXaWRhd3NreSA8WzNdYmVuQGJ3 aWRhd3NrLm5ldD4KPiA+ICAgICAgLS0tCj4gPiAgICAgIMKgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fY29udGV4dC5jIHwgNiArKystLS0KPiA+ICAgICAgwqBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dwdV9lcnJvci5jIMKgIHwgMiArLQo+ID4gICAgICDCoGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCB8IDIgKysKPiA+ICAgICAgwqAzIGZpbGVzIGNoYW5n ZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gICAgICBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jCj4gPiAgICAgIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jCj4gPiAgICAgIGluZGV4IGI5 YmFjMjUuLjBjMDQ0YTkgMTAwNjQ0Cj4gPiAgICAgIC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2NvbnRleHQuYwo+ID4gICAgICArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9jb250ZXh0LmMKPiA+ICAgICAgQEAgLTQwMyw3ICs0MDMsNyBAQCB2b2lkIGk5MTVf Z2VtX2NvbnRleHRfcmVzZXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+IAo+ID4gICAgICDC oCDCoCDCoCDCoCAvKiBQcmV2ZW50IHRoZSBoYXJkd2FyZSBmcm9tIHJlc3RvcmluZyB0aGUgbGFz dCBjb250ZXh0ICh3aGljaAo+ID4gICAgICBodW5nKSBvbgo+ID4gICAgICDCoCDCoCDCoCDCoCDC oCogdGhlIG5leHQgc3dpdGNoICovCj4gPiAgICAgIC0gwqAgwqAgwqAgZm9yIChpID0gMDsgaSA8 IEk5MTVfTlVNX1JJTkdTOyBpKyspIHsKPiA+ICAgICAgKyDCoCDCoCDCoCBmb3IgKGkgPSAwOyBp IDwgSTkxNV9BQ1RJVkVfUklOR1MoZGV2KTsgaSsrKSB7Cj4gPiAgICAgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcgPSAmZGV2X3ByaXYtPnJpbmdb aV07Cj4gPiAgICAgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHN0cnVjdCBpbnRlbF9jb250ZXh0 ICpkY3R4ID0gcmluZy0+ZGVmYXVsdF9jb250ZXh0Owo+ID4gCj4gPiAgICAgIEBAIC00NTYsNyAr NDU2LDcgQEAgaW50IGk5MTVfZ2VtX2NvbnRleHRfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KQo+ID4gICAgICDCoCDCoCDCoCDCoCB9Cj4gPiAKPiA+ICAgICAgwqAgwqAgwqAgwqAgLyogTkI6 IFJDUyB3aWxsIGhvbGQgYSByZWYgZm9yIGFsbCByaW5ncyAqLwo+ID4gICAgICAtIMKgIMKgIMKg IGZvciAoaSA9IDA7IGkgPCBJOTE1X05VTV9SSU5HUzsgaSsrKQo+ID4gICAgICArIMKgIMKgIMKg IGZvciAoaSA9IDA7IGkgPCBJOTE1X0FDVElWRV9SSU5HUyhkZXYpOyBpKyspCj4gPiAgICAgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIGRldl9wcml2LT5yaW5nW2ldLmRlZmF1bHRfY29udGV4dCA9 IGN0eDsKPiA+IAo+ID4gICAgICDCoCDCoCDCoCDCoCBEUk1fREVCVUdfRFJJVkVSKCIlcyBjb250 ZXh0IHN1cHBvcnQgaW5pdGlhbGl6ZWRcbiIsCj4gPiAgICAgIGRldl9wcml2LT5od19jb250ZXh0 X3NpemUgPyAiSFciIDogImZha2UiKTsKPiA+ICAgICAgQEAgLTQ5Myw3ICs0OTMsNyBAQCB2b2lk IGk5MTVfZ2VtX2NvbnRleHRfZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gICAgICDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbihkY3R4LT5v YmopOwo+ID4gICAgICDCoCDCoCDCoCDCoCB9Cj4gPiAKPiA+ICAgICAgLSDCoCDCoCDCoCBmb3Ig KGkgPSAwOyBpIDwgSTkxNV9OVU1fUklOR1M7IGkrKykgewo+ID4gICAgICArIMKgIMKgIMKgIGZv ciAoaSA9IDA7IGkgPCBJOTE1X0FDVElWRV9SSU5HUyhkZXYpOyBpKyspIHsKPiA+ICAgICAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZyA9ICZkZXZf cHJpdi0+cmluZ1tpXTsKPiA+IAo+ID4gICAgICDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBpZiAo cmluZy0+bGFzdF9jb250ZXh0KQo+ID4gICAgICBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+ID4gICAgICBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3B1X2Vycm9yLmMKPiA+ICAgICAgaW5kZXggODYzNjJkZS4uNmU1MjUwZCAxMDA2NDQKPiA+ ICAgICAgLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+ID4gICAg ICArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4gPiAgICAgIEBA IC04NDgsNyArODQ4LDcgQEAgc3RhdGljIHVpbnQzMl90IGk5MTVfZXJyb3JfZ2VuZXJhdGVfY29k ZShzdHJ1Y3QKPiA+ICAgICAgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgICAgIMKg IMKgIMKgIMKgIMKgKiBzeW5jaHJvbml6YXRpb24gY29tbWFuZHMgd2hpY2ggYWxtb3N0IGFsd2F5 cyBhcHBlYXIgaW4gdGhlCj4gPiAgICAgIGNhc2UKPiA+ICAgICAgwqAgwqAgwqAgwqAgwqAqIHN0 cmljdGx5IGEgY2xpZW50IGJ1Zy4gVXNlIGluc3Rkb25lIHRvIGRpZmZlcmVudGlhdGUgdGhvc2UK PiA+ICAgICAgc29tZS4KPiA+ICAgICAgwqAgwqAgwqAgwqAgwqAqLwo+ID4gICAgICAtIMKgIMKg IMKgIGZvciAoaSA9IDA7IGkgPCBJOTE1X05VTV9SSU5HUzsgaSsrKSB7Cj4gPiAgICAgICsgwqAg wqAgwqAgZm9yIChpID0gMDsgaSA8IEk5MTVfQUNUSVZFX1JJTkdTKGRldl9wcml2LT5kZXYpOyBp KyspIHsKPiA+ICAgICAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgaWYgKGVycm9yLT5yaW5nW2ld LmhhbmdjaGVja19hY3Rpb24gPT0gSEFOR0NIRUNLX0hVTkcpIHsKPiA+ICAgICAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgaWYgKHJpbmdfaWQpCj4gPiAgICAgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgICpyaW5nX2lkID0gaTsKPiA+ ICAgICAgZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIu aAo+ID4gICAgICBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ID4g ICAgICBpbmRleCBlNzIwMTdiLi42N2UyOTE5IDEwMDY0NAo+ID4gICAgICAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiA+ICAgICAgKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gPiAgICAgIEBAIC05MCw2ICs5MCw4IEBA IHN0cnVjdCDCoGludGVsX2VuZ2luZV9jcyB7Cj4gPiAgICAgIMKgIMKgIMKgIMKgIH0gaWQ7Cj4g PiAgICAgIMKgI2RlZmluZSBJOTE1X05VTV9SSU5HUyA1Cj4gPiAgICAgIMKgI2RlZmluZSBMQVNU X1VTRVJfUklORyAoVkVDUyArIDEpCj4gPiAgICAgICsjZGVmaW5lIEk5MTVfQUNUSVZFX1JJTkdT KGRldikgaHdlaWdodDgoSU5URUxfSU5GTyhkZXYpLT5yaW5nX21hc2spCj4gCj4gV2hhdCBkb2Vz IHRoZSBwb3Bjb3VudCBvZiB0aGUgbWFzayBoYXZlIHRvIGRvIHdpdGggdGhlIHZhbGlkaXR5IG9m IHRoZQo+IGFycmF5cyBiZWluZyBpdGVyYXRlZCBvdmVyIGluIHRoaXMgcGF0Y2g/Cj4gLUNocmlz CgpUaGUgcG9wY291bnQgb2YgdGhlIG1hc2sgcmVwcmVzZW50cyB0aGUgbnVtYmVyIG9mIHJpbmdz IGF2YWlsYWJsZSBvbiB0aGUKc3BlY2lmaWMgU0tVLCBhcyBvcHBvc2VkIHRvIHRoZSB0b3RhbCBu dW1iZXIgb2YgcmluZ3Mgb24gYW55IFNLVSBldmVyLgpJdCBpcyBub3QgYWx3YXlzIGNvcnJlY3Qg dG8gaXRlcmF0ZSBvbiBhbGwgcmluZ3MgaW4gdGhlIHN5c3RlbS4gUGxlYXNlCm5vdGUsIHRoZSBw YXRjaCBpcyBpbmNvbXBsZXRlLiBJIGhhdmUgYSBjb3VwbGUgb2Ygb3RoZXIsIHBlcmhhcHMgbW9y ZQppbnRlcmVzdGluZywgY2FzZXMgd2hpY2ggSSd2ZSBtaXNzZWQuCgotLSAKQmVuIFdpZGF3c2t5 LCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=