Re: [PATCH RFC 1/4] usb: add Marvell MVEBU USB support

From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	barebox@lists.infradead.org, Jason Cooper <jason@lakedaemon.net>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH RFC 1/4] usb: add Marvell MVEBU USB support
Date: Mon, 30 Jun 2014 08:30:06 +0200	[thread overview]
Message-ID: <20140630063006.GD14257@pengutronix.de> (raw)
In-Reply-To: <1403705328-9924-2-git-send-email-sebastian.hesselbarth@gmail.com>

Hi Sebastian,

> +	if (usb->mode == USB_DR_MODE_HOST &&
> +	    IS_ENABLED(CONFIG_USB_MVEBU_HOST)) {
> +		ret = regulator_enable(usb->vbus);
> +		if (ret)
> +			return ret;
> +		ret = ehci_register(dev, &usb->ehci);
> +		if (ret)
> +			regulator_disable(usb->vbus);
> +	} else if (usb->mode == USB_DR_MODE_PERIPHERAL &&
> +		   IS_ENABLED(CONFIG_USB_MVEBU_DEVICE)) {
> +		ret = regulator_disable(usb->vbus);
> +		if (ret)
> +			return ret;
> +		ret = ci_udc_register(dev, usb->base);
> +	} else {
> +		dev_err(dev, "Unsupported USB role\n");
> +		ret = -ENODEV;
> +	}

This should probably be shared between i.MX and mvebu. I have a patch
somewhere which implements a device parameter to switch between host and
device mode. It could be used for both i.MX and mvebu.

Otherwise the series looks fine to me.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox