From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41634)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X1Z6R-00070G-EQ
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 06:46:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X1Z6M-00027d-Q5
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 06:46:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38899)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X1Z6M-00027F-Hg
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 06:46:22 -0400
Date: Mon, 30 Jun 2014 13:46:43 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140630104643.GA19960@redhat.com>
References: <1404124095-3934-1-git-send-email-hutao@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1404124095-3934-1-git-send-email-hutao@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v2] numa: check for busy memory backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>, qemu-devel@nongnu.org

On Mon, Jun 30, 2014 at 06:28:15PM +0800, Hu Tao wrote:
> Specifying the same memory backend twice leads to an assert:
> 
> ./x86_64-softmmu/qemu-system-x86_64 -m 512M -enable-kvm -object
> memory-backend-ram,size=256M,id=ram0 -numa node,nodeid=0,memdev=ram0
> -numa node,nodeid=1,memdev=ram0
> qemu-system-x86_64: /scm/qemu/memory.c:1506:
> memory_region_add_subregion_common: Assertion `!subregion->container'
> failed.
> Aborted (core dumped)
> 
> Detect and exit with an error message instead.
> 
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>

Applied, thanks.

> ---
>  numa.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/numa.c b/numa.c
> index 2fde740..7bf7834 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -301,6 +301,14 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
>              exit(1);
>          }
>  
> +        if (memory_region_is_mapped(seg)) {
> +            char *path = object_get_canonical_path_component(OBJECT(backend));
> +            error_report("memory backend %s is used multiple times. Each "
> +                         "-numa option must use a different memdev value.",
> +                         path);
> +            exit(1);
> +        }
> +
>          memory_region_add_subregion(mr, addr, seg);
>          vmstate_register_ram_global(seg);
>          addr += size;
> -- 
> 1.9.3