All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	Gleb Natapov <gleb@kernel.org>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	"agraf@suse.de" <agraf@suse.de>,
	Alex Williamson <Alex.Williamson@redhat.com>
Subject: Re: [PATCH 1/2] KVM: device: add simple registration mechanism for kvm_device_ops
Date: Mon, 30 Jun 2014 12:11:17 +0100	[thread overview]
Message-ID: <20140630111117.GF25779@arm.com> (raw)
In-Reply-To: <53AD7D15.2010209@redhat.com>

On Fri, Jun 27, 2014 at 03:17:57PM +0100, Paolo Bonzini wrote:
> Il 26/06/2014 19:30, Will Deacon ha scritto:
> > kvm_ioctl_create_device currently has knowledge of all the device types
> > and their associated ops. This is fairly inflexible when adding support
> > for new in-kernel device emulations, so move what we currently have out
> > into a table, which can support dynamic registration of ops by new
> > drivers for virtual hardware.
> >
> > I didn't try to port all current drivers over, as it's not always clear
> > which initialisation hook the ops should be registered from.
> 
> Conny, Alex (Graf & Williamson),
> 
> can you help Will here?  The idea looks sane, but I'd rather merge it 
> with all devices converted.

Also, if we want to use an IDR instead of an array then dynamic registration
will be required, since I can't initialise the former statically.

I can convert kvm_vfio_ops with an initcall, but the others (mpic, xics and
flic) should probably hang off the host irqchip initialisation, no?

All help appreciated! I'm happy to collate diffs :) Failing that, I'll have
a crack at it myself, but I've got no way of testing the result.

Will

  reply	other threads:[~2014-06-30 11:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26 17:30 [PATCH 1/2] KVM: device: add simple registration mechanism for kvm_device_ops Will Deacon
2014-06-26 17:30 ` [PATCH 2/2] KVM: ARM: vgic: register kvm_device_ops dynamically Will Deacon
2014-06-27 14:17 ` [PATCH 1/2] KVM: device: add simple registration mechanism for kvm_device_ops Paolo Bonzini
2014-06-30 11:11   ` Will Deacon [this message]
2014-06-30 11:14   ` Cornelia Huck
2014-06-30 11:20     ` Will Deacon
2014-06-30  9:21 ` Cornelia Huck
2014-06-30  9:36   ` Will Deacon
2014-06-30 10:25     ` Cornelia Huck
2014-06-30 10:26       ` Will Deacon
2014-06-30 17:22   ` Paolo Bonzini
2014-06-30 17:27     ` Cornelia Huck
2014-06-30 17:31     ` Will Deacon
2014-06-30 17:32       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140630111117.GF25779@arm.com \
    --to=will.deacon@arm.com \
    --cc=Alex.Williamson@redhat.com \
    --cc=Marc.Zyngier@arm.com \
    --cc=agraf@suse.de \
    --cc=christoffer.dall@linaro.org \
    --cc=cornelia.huck@de.ibm.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.