From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: [PATCH 03/11] mini-os/xenbus: Add missing locks to xb_write Date: Mon, 30 Jun 2014 14:59:09 +0200 Message-ID: <20140630125909.GB5836@type.mobile.lan> References: <1403291090-8657-1-git-send-email-ian.jackson@eu.citrix.com> <1403291090-8657-4-git-send-email-ian.jackson@eu.citrix.com> <20140626120407.GS6046@type.bordeaux.inria.fr> <21425.23666.682091.39002@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X1bDC-0004px-8i for xen-devel@lists.xenproject.org; Mon, 30 Jun 2014 13:01:34 +0000 Content-Disposition: inline In-Reply-To: <21425.23666.682091.39002@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Keir Fraser , Ian Campbell List-Id: xen-devel@lists.xenproject.org Ian Jackson, le Mon 30 Jun 2014 13:47:46 +0100, a =E9crit : > > Well, yes, in its current form mini-os was not really meant to run with > > multiple processors. There are probably quite other issues like that in > > there. > = > Right. My approach has been that as I'm looking at this code in > detail and restructuring it, I ought to sort out the locking. It is > much easier to add locking as one goes along when working on a piece > of code, than to come along later and try to retrofit it. Indeed :) Samuel