From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: "Benoît Canet" <benoit.canet@irqsave.net>,
kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin
Date: Mon, 30 Jun 2014 16:25:47 +0200 [thread overview]
Message-ID: <20140630142546.GA17885@irqsave.net> (raw)
In-Reply-To: <20140630140957.GB10229@stefanha-thinkpad.redhat.com>
The Monday 30 Jun 2014 à 16:09:57 (+0200), Stefan Hajnoczi wrote :
> On Fri, Jun 27, 2014 at 10:17:16PM +0200, Benoît Canet wrote:
> I think this patch can be boiled down to 2 lines:
>
> if __name__ == '__main__':
> + if 'quorum' not in iotests.qemu_img('--help'):
> + iotests.notrun('not built with quorum support')
> iotests.main(supported_fmts=['qcow2', 'qed'])
>
> What do you think?
The detection part could work using qemu_img_pipe.
Are we sure that the test won't fail in strange ways like
when using skipTest ?
If so do you want me to respin this patch with your version ?
Best regards
Benoît
next prev parent reply other threads:[~2014-06-30 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 20:17 [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin Benoît Canet
2014-06-27 20:23 ` Kevin Wolf
2014-06-30 14:09 ` Stefan Hajnoczi
2014-06-30 14:25 ` Benoît Canet [this message]
2014-07-01 7:28 ` Stefan Hajnoczi
2014-07-01 8:10 ` Kevin Wolf
2014-07-01 8:45 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2014-07-01 11:34 Benoît Canet
2014-07-02 8:22 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630142546.GA17885@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.