From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: "Gabbay, Oded" <Oded.Gabbay-5C7GfCeVMHo@public.gmane.org>
Cc: "Sherry Cheung" <SCheung-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
"hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org"
<hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
"Jérôme Glisse"
<j.glisse-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Jatin Kumar" <jakumar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Lucien Dunning"
<ldunning-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"mgorman-l3A5Bk7waGM@public.gmane.org"
<mgorman-l3A5Bk7waGM@public.gmane.org>,
"jweiner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<jweiner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Subhash Gutti" <sgutti-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"John Hubbard" <jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Mark Hairgrove"
<mhairgrove-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Cameron Buschardt"
<cabuschardt-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"peterz-hDdKplPs4pWWVfeAwA7xHQ@public.gmane.org"
<peterz-hDdKplPs4pWWVfeAwA7xHQ@public.gmane.org>,
"Duncan Poole" <dpoole-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Cornwall, Jay" <Jay.Cornwall-5C7GfCeVMHo@public.gmane.org>,
"Lewycky, Andrew" <Andrew.Lewycky-5C7GfCeVMHo@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.
Date: Mon, 30 Jun 2014 17:40:42 +0200 [thread overview]
Message-ID: <20140630154042.GD26537@8bytes.org> (raw)
In-Reply-To: <019CCE693E457142B37B791721487FD91806B836-0nO7ALo/ziwxlywnonMhLEEOCMrvLtNR@public.gmane.org>
On Mon, Jun 30, 2014 at 02:41:24PM +0000, Gabbay, Oded wrote:
> I did face some problems regarding the amd IOMMU v2 driver, which
> changed its behavior (see commit "iommu/amd: Implement
> mmu_notifier_release call-back") to use mmu_notifier_release and did
> some "bad things" inside that
> notifier (primarily, but not only, deleting the object which held the
> mmu_notifier object itself, which you mustn't do because of the
> locking).
>
> I'm thinking of changing that driver's behavior to use this new
> mechanism instead of using mmu_notifier_release. Does that seem
> acceptable ? Another solution will be to add a new mmu_notifier call,
> but we already ruled that out ;)
The mmu_notifier_release() function is exactly what this new notifier
aims to do. Unless there is a very compelling reason to duplicate this
functionality I stronly NACK this approach.
Joerg
next prev parent reply other threads:[~2014-06-30 15:40 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 2:00 mm preparatory patches for HMM and IOMMUv2 Jérôme Glisse
2014-06-28 2:00 ` Jérôme Glisse
2014-06-28 2:00 ` [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler Jérôme Glisse
2014-06-28 2:00 ` Jérôme Glisse
2014-06-30 3:49 ` John Hubbard
2014-06-30 3:49 ` John Hubbard
2014-06-30 15:07 ` Jerome Glisse
2014-06-30 15:07 ` Jerome Glisse
2014-06-30 14:41 ` Gabbay, Oded
2014-06-30 14:41 ` Gabbay, Oded
[not found] ` <019CCE693E457142B37B791721487FD91806B836-0nO7ALo/ziwxlywnonMhLEEOCMrvLtNR@public.gmane.org>
2014-06-30 15:06 ` Jerome Glisse
2014-06-30 15:06 ` Jerome Glisse
2014-06-30 15:40 ` Joerg Roedel [this message]
2014-06-30 16:06 ` Jerome Glisse
2014-06-30 16:06 ` Jerome Glisse
2014-06-30 18:16 ` Joerg Roedel
2014-06-30 18:16 ` Joerg Roedel
2014-06-30 18:35 ` Jerome Glisse
2014-06-30 18:35 ` Jerome Glisse
2014-06-30 18:57 ` Lewycky, Andrew
2014-06-30 18:57 ` Lewycky, Andrew
2014-07-01 9:41 ` Joerg Roedel
2014-07-01 9:41 ` Joerg Roedel
[not found] ` <20140630183556.GB3280-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-01 9:15 ` Joerg Roedel
2014-07-01 9:29 ` Gabbay, Oded
2014-07-01 9:29 ` Gabbay, Oded
[not found] ` <019CCE693E457142B37B791721487FD91806DD8B-0nO7ALo/ziwxlywnonMhLEEOCMrvLtNR@public.gmane.org>
2014-07-01 11:00 ` Joerg Roedel
2014-07-01 19:33 ` Jerome Glisse
2014-07-01 19:33 ` Jerome Glisse
[not found] ` <20140701193343.GB3322-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-01 21:06 ` Joerg Roedel
2014-07-01 21:32 ` Jerome Glisse
2014-07-01 21:32 ` Jerome Glisse
2014-07-03 18:30 ` Jerome Glisse
2014-07-03 18:30 ` Jerome Glisse
[not found] ` <20140703183024.GA3306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-03 23:15 ` Joerg Roedel
2014-07-04 0:03 ` Jerome Glisse
2014-07-04 0:03 ` Jerome Glisse
[not found] ` <20140703231541.GR26537-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-07-06 19:25 ` Gabbay, Oded
2014-07-06 19:25 ` Gabbay, Oded
2014-07-07 10:11 ` joro
2014-07-07 10:11 ` joro
2014-07-07 10:36 ` Oded Gabbay
2014-07-07 10:36 ` Oded Gabbay
2014-07-07 10:43 ` Oded Gabbay
2014-07-07 10:43 ` Oded Gabbay
[not found] ` <1404729783.31606.1.camel-OrheeFI7RUaGvNAqNQFwiPZ4XP/Yx64J@public.gmane.org>
2014-07-08 8:00 ` joro-zLv9SwRftAIdnm+yROfE0A
[not found] ` <20140708080059.GF1958-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-07-08 17:03 ` Jerome Glisse
2014-07-08 17:03 ` Jerome Glisse
2015-10-11 19:03 ` David Woodhouse
2015-10-11 19:03 ` David Woodhouse
[not found] ` <1444590209.92154.116.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-10-12 17:41 ` Jerome Glisse
2015-10-12 17:41 ` Jerome Glisse
2015-10-12 17:41 ` Jerome Glisse
2015-11-20 15:45 ` David Woodhouse
2015-11-20 15:45 ` David Woodhouse
2014-06-30 15:37 ` Joerg Roedel
2014-06-28 2:00 ` [PATCH 2/6] mm: differentiate unmap for vmscan from other unmap Jérôme Glisse
2014-06-28 2:00 ` Jérôme Glisse
2014-06-30 3:58 ` John Hubbard
2014-06-30 3:58 ` John Hubbard
2014-06-30 15:58 ` Jerome Glisse
2014-06-30 15:58 ` Jerome Glisse
2014-06-28 2:00 ` [PATCH 3/6] mmu_notifier: add event information to address invalidation v2 Jérôme Glisse
2014-06-28 2:00 ` Jérôme Glisse
2014-06-30 5:22 ` John Hubbard
2014-06-30 5:22 ` John Hubbard
2014-06-30 15:57 ` Jerome Glisse
2014-06-30 15:57 ` Jerome Glisse
2014-07-01 1:57 ` Linus Torvalds
2014-06-28 2:00 ` [PATCH 4/6] mmu_notifier: pass through vma to invalidate_range and invalidate_page Jérôme Glisse
2014-06-28 2:00 ` Jérôme Glisse
2014-06-30 3:29 ` John Hubbard
2014-06-30 3:29 ` John Hubbard
2014-06-30 16:00 ` Jerome Glisse
2014-06-30 16:00 ` Jerome Glisse
2014-07-01 2:04 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630154042.GD26537@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=Andrew.Lewycky-5C7GfCeVMHo@public.gmane.org \
--cc=Jay.Cornwall-5C7GfCeVMHo@public.gmane.org \
--cc=Oded.Gabbay-5C7GfCeVMHo@public.gmane.org \
--cc=SCheung-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=cabuschardt-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=dpoole-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=j.glisse-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jakumar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=jweiner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ldunning-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mgorman-l3A5Bk7waGM@public.gmane.org \
--cc=mhairgrove-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=peterz-hDdKplPs4pWWVfeAwA7xHQ@public.gmane.org \
--cc=riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=sgutti-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.