From: Catalin Marinas <catalin.marinas@arm.com>
To: Hanjun Guo <hanjun.guo@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Helgaas <bhelgaas@google.com>,
"rric@kernel.org" <rric@kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Charles Garcia-Tobin <Charles.Garcia-Tobin@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
"graeme.gregory@linaro.org" <graeme.gregory@linaro.org>
Subject: Re: [PATCH v4 07/13] ARM64 / ACPI: Introduce lowlevel suspend function
Date: Mon, 30 Jun 2014 17:28:17 +0100 [thread overview]
Message-ID: <20140630162817.GS28951@arm.com> (raw)
In-Reply-To: <1403840976-7456-8-git-send-email-hanjun.guo@linaro.org>
On Fri, Jun 27, 2014 at 04:49:30AM +0100, Hanjun Guo wrote:
> From: Graeme Gregory <graeme.gregory@linaro.org>
>
> acpi_wakeup_address is used on x86 as the address bios jumps into
> when machine wakes up from suspend. As arm64 does not have such a
> bios this mechanism will be provided by other means. But the define
> is still required inside the acpi core.
Why not fix the place where it is used rather than defining a dummy
pointer?
> Introduce a null stub for acpi_suspend_lowlevel as this is also
> required by core. This will be filled in when standards are
> defined for arm64 ACPI global power states.
I assume acpi_suspend_lowlevel would be just a dummy definition but it
will have some use when the standard allows.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 07/13] ARM64 / ACPI: Introduce lowlevel suspend function
Date: Mon, 30 Jun 2014 17:28:17 +0100 [thread overview]
Message-ID: <20140630162817.GS28951@arm.com> (raw)
In-Reply-To: <1403840976-7456-8-git-send-email-hanjun.guo@linaro.org>
On Fri, Jun 27, 2014 at 04:49:30AM +0100, Hanjun Guo wrote:
> From: Graeme Gregory <graeme.gregory@linaro.org>
>
> acpi_wakeup_address is used on x86 as the address bios jumps into
> when machine wakes up from suspend. As arm64 does not have such a
> bios this mechanism will be provided by other means. But the define
> is still required inside the acpi core.
Why not fix the place where it is used rather than defining a dummy
pointer?
> Introduce a null stub for acpi_suspend_lowlevel as this is also
> required by core. This will be filled in when standards are
> defined for arm64 ACPI global power states.
I assume acpi_suspend_lowlevel would be just a dummy definition but it
will have some use when the standard allows.
--
Catalin
next prev parent reply other threads:[~2014-06-30 16:28 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 3:49 [PATCH v4 00/13] Enable ACPI on ARM64 in Kconfig Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 3:49 ` [PATCH v4 01/13] acpi: arm64 does not have a BIOS add config for BIOS table scan Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 3:49 ` [PATCH v4 02/13] ACPI: Don't use acpi_lapic in ACPI core code Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 3:49 ` [PATCH v4 03/13] ACPI / processor: Introduce ARCH_HAS_ACPI_PDC Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 3:49 ` [PATCH v4 04/13] ARM64 : Add dummy asm/cpu.h Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 3:49 ` [PATCH v4 05/13] ARM64 / ACPI: Introduce arm-core.c and its related head file Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-30 16:24 ` Catalin Marinas
2014-06-30 16:24 ` Catalin Marinas
2014-06-30 17:21 ` Graeme Gregory
2014-06-30 17:21 ` Graeme Gregory
2014-06-27 3:49 ` [PATCH v4 06/13] ARM64 / ACPI: Introduce early_param for "acpi" Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 9:07 ` Arnd Bergmann
2014-06-27 9:07 ` Arnd Bergmann
2014-06-27 10:57 ` Graeme Gregory
2014-06-27 10:57 ` Graeme Gregory
2014-06-27 10:57 ` Graeme Gregory
2014-06-27 3:49 ` [PATCH v4 07/13] ARM64 / ACPI: Introduce lowlevel suspend function Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-30 16:28 ` Catalin Marinas [this message]
2014-06-30 16:28 ` Catalin Marinas
2014-06-27 3:49 ` [PATCH v4 08/13] ARM64 / ACPI: Introduce arch_fix_phys_package_id() for cpu topology Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 3:49 ` [PATCH v4 09/13] ARM64 / ACPI: Introduce PCI functions for ACPI on ARM64 Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 3:49 ` [PATCH v4 10/13] ACPI: Make EC debugfs depend on X86 || IA64 in Kconfig Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 3:49 ` [PATCH v4 11/13] ARM64 / ACPI: Select ACPI_REDUCED_HARDWARE_ONLY if ACPI is enabled on ARM64 Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 3:49 ` [PATCH v4 12/13] ARM64 / ACPI: if we chose to boot from acpi then disable FDT Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-27 9:09 ` [Linaro-acpi] " Arnd Bergmann
2014-06-27 9:09 ` Arnd Bergmann
2014-06-27 3:49 ` [PATCH v4 13/13] ARM64 / ACPI: Enable ARM64 in Kconfig Hanjun Guo
2014-06-27 3:49 ` Hanjun Guo
2014-06-30 10:46 ` Catalin Marinas
2014-06-30 10:46 ` Catalin Marinas
2014-07-01 7:54 ` Hanjun Guo
2014-07-01 7:54 ` Hanjun Guo
2014-07-01 8:20 ` Hanjun Guo
2014-07-01 8:20 ` Hanjun Guo
2014-07-01 9:22 ` Catalin Marinas
2014-07-01 9:22 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630162817.GS28951@arm.com \
--to=catalin.marinas@arm.com \
--cc=Charles.Garcia-Tobin@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=graeme.gregory@linaro.org \
--cc=grant.likely@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.