From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] usb: ci_udc: Allocate the qTD list directly
Date: Tue, 1 Jul 2014 12:17:41 +0200 [thread overview]
Message-ID: <201407011217.41490.marex@denx.de> (raw)
In-Reply-To: <53B25A81.6000208@posteo.de>
On Tuesday, July 01, 2014 at 08:51:45 AM, J?rg Krause wrote:
> On 07/01/2014 02:04 AM, Marek Vasut wrote:
> > Instead of weird allocation of ci_drv->items_mem and then even weirder
> > distribution of offsets in this memory area into ci_drv->items array,
> > just allocate ci_drv->items as a big slab of aligned memory (replaces
> > ci_drv->items_mem) and let ci_get_qtd() do the distribution of offsets
> > in this memory area.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: J?rg Krause <jkrause@posteo.de>
> > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > ---
> >
> > drivers/usb/gadget/ci_udc.c | 19 ++++++-------------
> > drivers/usb/gadget/ci_udc.h | 3 +--
> > 2 files changed, 7 insertions(+), 15 deletions(-)
> >
> > V2: Rebase on top of u-boot-usb/master instead of the research branch
[...]
> I made a test on u-boot-arm/master before (Test#1) and after applying
> this patch (Test#2).
Can we please sync on the same codebase (u-boot-usb/master) ?
> After a reset I run this script:
> test_usb=setenv i 64; while test ${i} -gt 0; do echo ${i}; tftp
> ${rootfs_file}; setexpr i ${i} - 1; done; setenv i;
>
> Both tests (Test#1 and Test#2) runs fine with the script. But if I do
> run tftp ${rootfs_file} manually from the console, I get the known error
> starting the fourth run for both Test#1 and Test#2.
Can you edit arch/arm/cpu/arm926ejs/cache.c and change the debug() to printf() ,
then re-test please ? I suspect this might trap something still. Ah, and please
test on u-boot-usb/master with this patch.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-07-01 10:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 23:53 [U-Boot] [PATCH] usb: ci_udc: Allocate the qTD list directly Marek Vasut
2014-06-30 23:55 ` Marek Vasut
2014-07-01 0:04 ` [U-Boot] [PATCH V2] " Marek Vasut
2014-07-01 6:51 ` Jörg Krause
2014-07-01 10:17 ` Marek Vasut [this message]
2014-07-01 11:03 ` Jörg Krause
2014-07-01 11:19 ` Marek Vasut
2014-07-01 11:22 ` Jörg Krause
2014-07-01 11:35 ` Marek Vasut
2014-07-01 11:48 ` Jörg Krause
2014-07-01 22:34 ` Jörg Krause
2014-07-01 22:36 ` Stephen Warren
2014-07-01 22:47 ` Jörg Krause
2014-07-01 22:51 ` Stephen Warren
2014-07-01 22:57 ` Jörg Krause
2014-07-01 23:10 ` Stephen Warren
2014-07-01 15:03 ` Stephen Warren
2014-07-01 15:13 ` Marek Vasut
2014-07-01 15:16 ` Stephen Warren
2014-07-01 15:22 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201407011217.41490.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.