Re: [Qemu-devel] [RFC PATCH v4] numa: enable sparse node numbering on ppc

[Nishanth Aravamudan <nacc@linux.vnet.ibm.com>]

On 01.07.2014 [12:24:48 -0300], Eduardo Habkost wrote:
> On Mon, Jun 30, 2014 at 02:34:56PM -0700, Nishanth Aravamudan wrote:
> [...]
> >              }
> > +	    assert(numa_info[i].present);
> >              numa_info[i].node_mem = ram_size - usedmem;
> >          }
> 
> Tab here.
> 
> >  
> [...]
> > +            for (i = 0, j = 0; i < max_cpus; i++) {
> > +		do {
> > +                    j = (j + 1) % (max_numa_nodeid);
> > +		} while (!numa_info[j].present);
> 
> Ditto.
> 
> (Those can be detected using checkpatch.pl).

Grr, sorry, I had been using checkpatch, but rushed this one. My
apologies!

> Other than that, the PC changes look good to me (I haven't reviewed the
> spapr.c changes). But I have an additional request: can you submit the
> nb_numa_nodes/num_numa_nodes rename as a separate patch, to make the
> other changes more visible and easier to review?

Yep, that makes sense.

Thanks,
Nish