From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c Date: Tue, 1 Jul 2014 23:55:32 -0700 Message-ID: <20140702065531.GS28884@atomide.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Nick Krause Cc: Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, "linux-kernel@vger.kernel.org" List-Id: linux-omap@vger.kernel.org * Nick Krause [140701 15:51]: > Hey Tony and Russel , > There is a FIX ME message in this function of the file stated in my > subject line. > I was wondering what locking is needed here due to not having experience with > omap subsystem(s). Looks like the locking for ocpi_enable would be needed if it was called from multiple drivers. We are just enabling all access, so no locking neeed for the current usage. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 1 Jul 2014 23:55:32 -0700 Subject: FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c In-Reply-To: References: Message-ID: <20140702065531.GS28884@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Nick Krause [140701 15:51]: > Hey Tony and Russel , > There is a FIX ME message in this function of the file stated in my > subject line. > I was wondering what locking is needed here due to not having experience with > omap subsystem(s). Looks like the locking for ocpi_enable would be needed if it was called from multiple drivers. We are just enabling all access, so no locking neeed for the current usage. Regards, Tony