From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1] virtio: move common virtio properties to bus class device
Date: Wed, 2 Jul 2014 13:35:02 +0300 [thread overview]
Message-ID: <20140702103502.GA5286@redhat.com> (raw)
In-Reply-To: <CACVXFVPhcWAtObqL=_EQ7+5_y6CJ+5PtJD3xr1=fiFiVB_9-kQ@mail.gmail.com>
On Wed, Jul 02, 2014 at 07:27:45PM +0800, Ming Lei wrote:
> On Wed, Jul 2, 2014 at 5:58 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Jul 01, 2014 at 12:01:58AM +0800, Ming Lei wrote:
> >> The two common virtio features can be defined per bus, so move all
> >> into bus class device to make code more clean.
> >>
> >> As discussed with cornelia, s390-virtio-blk doesn't support
> >> the two features at all, so keep s390-virtio as it.
> >>
> >> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> #for s390 ccw
> >> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> >> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> >
> > Looks like this got merged meanwhile:
> > commit caffdac363801cd2cf2bf01ad013a8c1e1e43800
> > Author: Stefan Hajnoczi <stefanha@redhat.com>
> > Date: Wed Jun 18 17:58:33 2014 +0800
> >
> > virtio-blk: use aliases instead of duplicate qdev properties
> >
> > so there was a conflict again.
> >
> > I resolved it, but pls check out pci branch in my tree
> > and verify that it's all good to go.
>
> Could you share me your tree?
>
> Thanks,
> --
> Ming Lei
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci
next prev parent reply other threads:[~2014-07-02 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 16:01 [Qemu-devel] [PATCH v1] virtio: move common virtio properties to bus class device Ming Lei
2014-07-02 9:58 ` Michael S. Tsirkin
2014-07-02 11:27 ` Ming Lei
2014-07-02 10:35 ` Michael S. Tsirkin [this message]
2014-07-02 12:27 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702103502.GA5286@redhat.com \
--to=mst@redhat.com \
--cc=ming.lei@canonical.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.