From: Mark Brown <broonie@kernel.org>
To: Jianqun <xjq@rock-chips.com>
Cc: Huang Tao <huangtao@rock-chips.com>,
heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.de, grant.likely@linaro.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, zhangqing@rock-chips.com,
hj@rock-chips.com, kever.yang@rock-chips.com, zyw@rock-chips.com,
yzq@rock-chips.com, zhenfu.fang@rock-chips.com,
cf@rock-chips.com, kfx@rock-chips.com
Subject: Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller
Date: Wed, 2 Jul 2014 12:16:36 +0100 [thread overview]
Message-ID: <20140702111636.GD410@sirena.org.uk> (raw)
In-Reply-To: <53B3E5AA.9060300@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Wed, Jul 02, 2014 at 06:57:46PM +0800, Jianqun wrote:
> Hi Mark:
Don't top post.
> Since regmap_update_bits is int style, I have to error check every time after call it.
> Also I find that the tegra_i2s.c call the function without error checking,
> Could you tell me the right way to handle the regmap_update_bits ?
With memory mapped I/O there's no real point in checking for errors so
if you kno0w your device is memory mapped you can get away with just
ignoring them.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-02 11:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 8:37 [PATCH 0/2] add rockchip i2s driver jianqun
2014-07-01 8:37 ` jianqun
[not found] ` <1404203860-30712-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01 8:37 ` [PATCH 1/2] ASoC: dt-bindings: add rockchip i2s bindings jianqun
2014-07-01 8:37 ` jianqun
[not found] ` <1404203860-30712-2-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01 8:54 ` Mark Rutland
2014-07-01 8:54 ` Mark Rutland
2014-07-01 10:08 ` jianqun
2014-07-01 10:08 ` jianqun
2014-07-04 7:26 ` [PATCH v2 " jianqun
[not found] ` <1404458796-6818-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-04 16:55 ` Mark Rutland
2014-07-04 16:55 ` Mark Rutland
2014-07-05 11:10 ` [PATCH v3 " jianqun
[not found] ` <1404558638-1739-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-09 7:40 ` Mark Brown
2014-07-09 7:40 ` Mark Brown
2014-07-01 8:47 ` [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller jianqun
[not found] ` <1404204458-30881-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01 9:01 ` Mark Rutland
2014-07-01 9:01 ` Mark Rutland
2014-07-01 9:51 ` [alsa-devel] " Lars-Peter Clausen
2014-07-01 9:51 ` Lars-Peter Clausen
[not found] ` <53B2CA5E.1060401@rock-chips.com>
2014-07-01 14:57 ` Lars-Peter Clausen
2014-07-01 15:17 ` Huang Tao
2014-07-01 17:07 ` Mark Brown
2014-07-01 17:07 ` Mark Brown
2014-07-02 1:01 ` Huang Tao
2014-07-02 1:01 ` Huang Tao
[not found] ` <53B359FD.3080809-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-02 10:23 ` Mark Brown
2014-07-02 10:23 ` Mark Brown
2014-07-02 10:57 ` Jianqun
2014-07-02 11:16 ` Mark Brown [this message]
2014-07-04 7:29 ` [PATCH v2 " jianqun
2014-07-04 7:29 ` jianqun
2014-07-05 11:13 ` [PATCH v3 " jianqun
2014-07-05 11:13 ` jianqun
-- strict thread matches above, loose matches on Subject: below --
2014-07-01 8:39 [PATCH " jianqun
2014-07-01 8:39 ` jianqun
[not found] ` <1404203972-30760-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01 9:32 ` Varka Bhadram
2014-07-01 9:32 ` Varka Bhadram
[not found] ` <53B28029.90408-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-01 10:11 ` Heiko Stübner
2014-07-01 10:11 ` Heiko Stübner
2014-07-11 9:54 [PATCH 0/2] add rockchip i2s driver jianqun
2014-07-11 9:58 ` [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller jianqun
2014-07-11 9:58 ` jianqun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702111636.GD410@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=hj@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=kfx@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
--cc=xjq@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zhenfu.fang@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.