From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Felipe Balbi <balbi@ti.com>, Darren Etheridge <detheridge@ti.com>,
bcousson@baylibre.com, wsa@sang-engineering.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ARM: dts: am335x-evmsk: enable display and lcd panel support
Date: Wed, 2 Jul 2014 04:50:10 -0700 [thread overview]
Message-ID: <20140702115010.GW28884@atomide.com> (raw)
In-Reply-To: <53B3E731.5030604@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [140702 04:06]:
> On 02/07/14 10:45, Tony Lindgren wrote:
> > * Felipe Balbi <balbi@ti.com> [140701 14:10]:
> >> Hi,
> >>
> >> On Tue, Jul 01, 2014 at 04:00:20PM -0500, Darren Etheridge wrote:
> >>> Add the necessary nodes to enable the LCD controller and the
> >>> LCD panel that is attached to the Texas Instruments AM335x
> >>> EVMSK platform. Also setup the necessary pin mux within the
> >>> DT file to drive the LCD connector and add the correct
> >>> pinmux settings for the lcd pins to be configured to when
> >>> the SoC goes into sleep state for the minimum power
> >>> consumption.
> >>>
> >>> For the sleep mode LCD pin settings, MUX_MODE7 is chosen as
> >>> this corresponds to switching the pins into input GPIO's with
> >>> an internal pulldown. Which has been determined to offer the
> >>> lowest power solution vs leaving the pins configured in LCD
> >>> mode.
> >>>
> >>> Signed-off-by: Darren Etheridge <detheridge@ti.com>
> >>> Acked-by: Wolfram Sang <wsa@sang-engineering.com>
> >>
> >> Tested-by: Felipe Balbi <balbi@ti.com>
> >>
> >> serial console capture: http://slexy.org/view/s200thiMb3
> >>
> >> note that v2 has been pending since May 9th:
> >> http://marc.info/?l=linux-omap&m=139966159102339&w=2
> >>
> >>> ---
> >>> Tony, Benoit,
> >>>
> >>> I didn't see this patch get applied anywhere, so I updated it and I am
> >>> resending it. Please let me know if you need any more info before you will
> >>> apply it.
> >
> > Tomi, do you want to ack this one or want to queue the panel .dts
> > changes into a separate branch?
>
> I don't really have experience with the LCDC used on AM335x SoC (it
> doesn't have DSS), but the patch looks ok, so for what it's worth:
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> I don't have any .dts changes queued, so I think it's better if you pick
> it up.
OK thanks applying into omap-for-v3.17/dt.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: dts: am335x-evmsk: enable display and lcd panel support
Date: Wed, 2 Jul 2014 04:50:10 -0700 [thread overview]
Message-ID: <20140702115010.GW28884@atomide.com> (raw)
In-Reply-To: <53B3E731.5030604@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [140702 04:06]:
> On 02/07/14 10:45, Tony Lindgren wrote:
> > * Felipe Balbi <balbi@ti.com> [140701 14:10]:
> >> Hi,
> >>
> >> On Tue, Jul 01, 2014 at 04:00:20PM -0500, Darren Etheridge wrote:
> >>> Add the necessary nodes to enable the LCD controller and the
> >>> LCD panel that is attached to the Texas Instruments AM335x
> >>> EVMSK platform. Also setup the necessary pin mux within the
> >>> DT file to drive the LCD connector and add the correct
> >>> pinmux settings for the lcd pins to be configured to when
> >>> the SoC goes into sleep state for the minimum power
> >>> consumption.
> >>>
> >>> For the sleep mode LCD pin settings, MUX_MODE7 is chosen as
> >>> this corresponds to switching the pins into input GPIO's with
> >>> an internal pulldown. Which has been determined to offer the
> >>> lowest power solution vs leaving the pins configured in LCD
> >>> mode.
> >>>
> >>> Signed-off-by: Darren Etheridge <detheridge@ti.com>
> >>> Acked-by: Wolfram Sang <wsa@sang-engineering.com>
> >>
> >> Tested-by: Felipe Balbi <balbi@ti.com>
> >>
> >> serial console capture: http://slexy.org/view/s200thiMb3
> >>
> >> note that v2 has been pending since May 9th:
> >> http://marc.info/?l=linux-omap&m=139966159102339&w=2
> >>
> >>> ---
> >>> Tony, Benoit,
> >>>
> >>> I didn't see this patch get applied anywhere, so I updated it and I am
> >>> resending it. Please let me know if you need any more info before you will
> >>> apply it.
> >
> > Tomi, do you want to ack this one or want to queue the panel .dts
> > changes into a separate branch?
>
> I don't really have experience with the LCDC used on AM335x SoC (it
> doesn't have DSS), but the patch looks ok, so for what it's worth:
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> I don't have any .dts changes queued, so I think it's better if you pick
> it up.
OK thanks applying into omap-for-v3.17/dt.
Regards,
Tony
next prev parent reply other threads:[~2014-07-02 11:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 21:00 [PATCH v3] ARM: dts: am335x-evmsk: enable display and lcd panel support Darren Etheridge
2014-07-01 21:00 ` Darren Etheridge
2014-07-01 21:08 ` Felipe Balbi
2014-07-01 21:08 ` Felipe Balbi
2014-07-02 7:45 ` Tony Lindgren
2014-07-02 7:45 ` Tony Lindgren
2014-07-02 11:04 ` Tomi Valkeinen
2014-07-02 11:04 ` Tomi Valkeinen
2014-07-02 11:50 ` Tony Lindgren [this message]
2014-07-02 11:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702115010.GW28884@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=detheridge@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=wsa@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.