From: Richard Cochran <richardcochran@gmail.com>
To: "Stefan Sørensen" <stefan.sorensen@spectralink.com>
Cc: davem@davemloft.net, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next repost v2 1/3] net: Simplify ptp class checks
Date: Wed, 2 Jul 2014 19:48:15 +0200 [thread overview]
Message-ID: <20140702174815.GA8388@localhost.localdomain> (raw)
In-Reply-To: <1404312104-19154-2-git-send-email-stefan.sorensen@spectralink.com>
On Wed, Jul 02, 2014 at 04:41:42PM +0200, Stefan Sørensen wrote:
> Replace two switch statements enumerating all valid ptp classes with an if
> statement matching for not PTP_CLASS_NONE.
Originally, I had the explicit list to guard against the possibility
of a filter returning early without some valid PTP_CLASS. I agree with
this change, but we will have to remember to make sure the filter
always returns NONE when the packet isn't recognized.
Acked-by: Richard Cochran <richardcochran@gmail.com>
next parent reply other threads:[~2014-07-02 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1404312104-19154-1-git-send-email-stefan.sorensen@spectralink.com>
[not found] ` <1404312104-19154-2-git-send-email-stefan.sorensen@spectralink.com>
2014-07-02 17:48 ` Richard Cochran [this message]
[not found] ` <1404312104-19154-3-git-send-email-stefan.sorensen@spectralink.com>
2014-07-05 18:58 ` [PATCH net-next repost v2 2/3] ptp: Classify ptp over ip over vlan packets Richard Cochran
[not found] ` <1404312104-19154-4-git-send-email-stefan.sorensen@spectralink.com>
2014-07-05 18:59 ` [PATCH net-next repost v2 3/3] vlan: Pass SIOC[SG]HWTSTAMP ioctls to real device Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702174815.GA8388@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.