All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] rcu: uninline rcu_read_lock_held()
Date: Wed, 2 Jul 2014 20:59:15 +0200	[thread overview]
Message-ID: <20140702185915.GA18357@redhat.com> (raw)
In-Reply-To: <20140702153901.GA9535@redhat.com>

On 07/02, Oleg Nesterov wrote:
>
> And this naturally suggests that rcu_read_lock_held() should be uninlined
> too (and rcu_read_lock_sched_held(), but this needs another patch).
>
> But I still can't understand the difference reported by "size vmlinux",
>
> 	- 5541731 3014560 14757888 23314179
> 	+ 5513182 3026848 14757888 23297918
>
> it removes 28K from .text, but somehow it adds 12K to .data. I do not
> see any difference in .data when I compare individual .o files before/
> after this patch.

OK, it doesn't add to .data. This is because of INIT_TASK_DATA(THREAD_SIZE)
in vmlinux.lds.S, see the changelog.

If you think this makes sense I will will spam you again. We can also
uninline rcu_read_lock_sched_held(), mostly for consistency. But this
needs a separate change.

Oleg.


  reply	other threads:[~2014-07-02 19:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 16:18 [PATCH v4 0/2] rcu: uninline rcu_lock_acquire() and rcu_lock_release() Oleg Nesterov
2014-06-30 16:18 ` [PATCH v4 1/2] " Oleg Nesterov
2014-07-01 11:41   ` Peter Zijlstra
2014-07-01 16:40     ` Oleg Nesterov
2014-07-08 22:22       ` Paul E. McKenney
2014-06-30 16:18 ` [PATCH v4 2/2] rcu: change rcu_dereference_check(c) to check "c" first Oleg Nesterov
2014-06-30 20:24 ` [PATCH v4 0/2] rcu: uninline rcu_lock_acquire() and rcu_lock_release() Paul E. McKenney
2014-07-01 14:55   ` Oleg Nesterov
2014-07-02 15:39     ` Oleg Nesterov
2014-07-02 18:59       ` Oleg Nesterov [this message]
2014-07-02 18:59         ` [PATCH 1/1] rcu: uninline rcu_read_lock_held() Oleg Nesterov
2014-07-08 22:20           ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140702185915.GA18357@redhat.com \
    --to=oleg@redhat.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.