From: Bjorn Helgaas <bhelgaas@google.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: jg1.han@samsung.com, linux-pci@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] PCI: designware: Use IS_ENABLED()
Date: Wed, 2 Jul 2014 16:24:38 -0600 [thread overview]
Message-ID: <20140702222438.GE28852@google.com> (raw)
In-Reply-To: <1403104613-9867-1-git-send-email-festevam@gmail.com>
On Wed, Jun 18, 2014 at 12:16:53PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We can get rid of the 'ifdef' by using the IS_ENABLED() macro.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied with Jingoo and Mohit's acks to pci/host-designware for v3.17,
thanks!
> ---
> drivers/pci/host/pcie-designware.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 1eaf4df3..dc842fd 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -497,9 +497,8 @@ int __init dw_pcie_host_init(struct pcie_port *pp)
>
> pci_common_init_dev(pp->dev, &dw_pci);
> pci_assign_unassigned_resources();
> -#ifdef CONFIG_PCI_DOMAINS
> - dw_pci.domain++;
> -#endif
> + if (IS_ENABLED(CONFIG_PCI_DOMAINS))
> + dw_pci.domain++;
>
> return 0;
> }
> --
> 1.8.3.2
>
next prev parent reply other threads:[~2014-07-02 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 15:16 [PATCH] PCI: designware: Use IS_ENABLED() Fabio Estevam
2014-06-19 0:10 ` Jingoo Han
2014-06-19 3:49 ` Mohit KUMAR DCG
2014-07-02 22:24 ` Bjorn Helgaas [this message]
2014-07-09 0:57 ` Stephen Rothwell
2014-07-09 1:34 ` Jingoo Han
2014-07-09 3:40 ` Bjorn Helgaas
2014-07-09 6:04 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702222438.GE28852@google.com \
--to=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.