From: Kees Cook <kees@outflux.net>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, sfr@canb.auug.org.au, mhocko@suse.cz,
Andi Kleen <ak@linux.intel.com>
Subject: Re: mmotm 2014-07-02-15-07 uploaded (stack protector)
Date: Wed, 2 Jul 2014 17:57:19 -0700 [thread overview]
Message-ID: <20140703005719.GJ5412@outflux.net> (raw)
In-Reply-To: <53B493E2.2030905@infradead.org>
Hi Randy,
And to explain more specifically what's happening:
On Wed, Jul 02, 2014 at 04:21:06PM -0700, Randy Dunlap wrote:
> config-r8736:CONFIG_CC_STACKPROTECTOR_STRONG=y
> [...]
> build-r8736.out:/local/lnx/MM/mmotm-2014-0702-1507/Makefile:662: Cannot use CONFIG_CC_STACKPROTECTOR_STRONG: -fstack-protector-strong not supported by compiler
> build-r8736.out:/local/lnx/MM/mmotm-2014-0702-1507/Makefile:662: Cannot use CONFIG_CC_STACKPROTECTOR_STRONG: -fstack-protector-strong not supported by compiler
> gcc: error: unrecognized command line option '-fstack-protector-strong'
That makes sense: a feature that requires a specific compiler version was
chosen, so you get a warning and a failed build. (The first warning was
during the .config parsing pass, the second warning was during the binary
build pass.)
> config-r8737:# CONFIG_CC_STACKPROTECTOR_STRONG is not set
> [...]
> build-r8737.out:/local/lnx/MM/mmotm-2014-0702-1507/Makefile:662: Cannot use CONFIG_CC_STACKPROTECTOR_STRONG: -fstack-protector-strong not supported by compiler
This is the same issue: the prior .config was still there with STRONG set,
but after finishing the new .config parsing pass, everything is happy for
the binary build pass. And, I assume, the r8737 didn't fail to build.
The trouble seems to be how kbuild handle .config changes, but I was never
able to sort it out.
-Kees
--
Kees Cook @outflux.net
next prev parent reply other threads:[~2014-07-03 0:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 22:08 mmotm 2014-07-02-15-07 uploaded akpm
2014-07-02 22:08 ` akpm
2014-07-02 23:21 ` mmotm 2014-07-02-15-07 uploaded (stack protector) Randy Dunlap
2014-07-03 0:22 ` Andi Kleen
2014-07-03 0:37 ` Randy Dunlap
2014-07-03 0:51 ` Kees Cook
2014-07-03 0:56 ` Andrew Morton
2014-07-03 1:10 ` [PATCH] kbuild: explain stack-protector-strong CONFIG logic Kees Cook
2014-07-03 1:00 ` mmotm 2014-07-02-15-07 uploaded (stack protector) Andi Kleen
2014-07-03 1:13 ` Kees Cook
2014-07-03 0:57 ` Kees Cook [this message]
2014-07-03 1:42 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703005719.GJ5412@outflux.net \
--to=kees@outflux.net \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.